Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8309)

Unified Diff: base/debug/trace_event_impl.cc

Issue 510563002: Remove implicit conversions from scoped_refptr to T* in base/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Propagate Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/files/important_file_writer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/debug/trace_event_impl.cc
diff --git a/base/debug/trace_event_impl.cc b/base/debug/trace_event_impl.cc
index 5c521d462fe0e73c766d801f1b4340ad2d82670f..cce900c2e61b6d8e1482d421069576b981a33b7e 100644
--- a/base/debug/trace_event_impl.cc
+++ b/base/debug/trace_event_impl.cc
@@ -1786,7 +1786,7 @@ void TraceLog::FinishFlush(int generation) {
void TraceLog::FlushCurrentThread(int generation) {
{
AutoLock lock(lock_);
- if (!CheckGeneration(generation) || !flush_message_loop_proxy_) {
+ if (!CheckGeneration(generation) || !flush_message_loop_proxy_.get()) {
// This is late. The corresponding flush has finished.
return;
}
@@ -1796,7 +1796,7 @@ void TraceLog::FlushCurrentThread(int generation) {
delete thread_local_event_buffer_.Get();
AutoLock lock(lock_);
- if (!CheckGeneration(generation) || !flush_message_loop_proxy_ ||
+ if (!CheckGeneration(generation) || !flush_message_loop_proxy_.get() ||
thread_message_loops_.size())
return;
@@ -1808,7 +1808,7 @@ void TraceLog::FlushCurrentThread(int generation) {
void TraceLog::OnFlushTimeout(int generation) {
{
AutoLock lock(lock_);
- if (!CheckGeneration(generation) || !flush_message_loop_proxy_) {
+ if (!CheckGeneration(generation) || !flush_message_loop_proxy_.get()) {
// Flush has finished before timeout.
return;
}
« no previous file with comments | « no previous file | base/files/important_file_writer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698