src/utils/SkPDFRasterizer.cpp - Issue 510423005: make allocPixels throw on failure

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/utils/SkPDFRasterizer.cpp

Issue 510423005: make allocPixels throw on failure (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/utils/SkPDFRasterizer.cpp

diff --git a/src/utils/SkPDFRasterizer.cpp b/src/utils/SkPDFRasterizer.cpp

index 66634804bc6aa2371ecf983eae50fb8a16c5d5d8..1cb792fb817084cd002af0f68905a6776daf6ce8 100644

--- a/src/utils/SkPDFRasterizer.cpp

+++ b/src/utils/SkPDFRasterizer.cpp

@@ -50,7 +50,7 @@ bool SkPopplerRasterizePDF(SkStream* pdf, SkBitmap* output) {

char *imgData = image.data();

SkBitmap bitmap;

- if (!bitmap.allocPixels(SkImageInfo::MakeN32Premul(width, height))) {

+ if (!bitmap.tryAllocN32Pixels(width, height)) {

return false;

}

bitmap.eraseColor(SK_ColorWHITE);

« no previous file with comments | « src/pdf/SkPDFImage.cpp ('k') | src/utils/mac/SkCreateCGImageRef.cpp » ('j') | no next file with comments »