src/pdf/SkPDFImage.cpp - Issue 510423005: make allocPixels throw on failure

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/pdf/SkPDFImage.cpp

Issue 510423005: make allocPixels throw on failure (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/pdf/SkPDFImage.cpp

diff --git a/src/pdf/SkPDFImage.cpp b/src/pdf/SkPDFImage.cpp

index 49460510d9b6f4ef8eb140c3b4c147c0470779d1..0c9b7417a1d1254bca2cf618b182c75f87335b90 100644

--- a/src/pdf/SkPDFImage.cpp

+++ b/src/pdf/SkPDFImage.cpp

@@ -375,8 +375,7 @@ static uint16_t get_argb4444_neighbor_avg_color(const SkBitmap& bitmap,

static SkBitmap unpremultiply_bitmap(const SkBitmap& bitmap,

const SkIRect& srcRect) {

SkBitmap outBitmap;

- SkAssertResult(outBitmap.allocPixels(

- bitmap.info().makeWH(srcRect.width(), srcRect.height())));

+ outBitmap.allocPixels(bitmap.info().makeWH(srcRect.width(), srcRect.height()));

int dstRow = 0;

SkAutoLockPixels outBitmapPixelLock(outBitmap);

« no previous file with comments | « src/pdf/SkPDFDevice.cpp ('k') | src/utils/SkPDFRasterizer.cpp » ('j') | no next file with comments »