src/images/SkImageDecoder.cpp - Issue 510423005: make allocPixels throw on failure

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/images/SkImageDecoder.cpp

Issue 510423005: make allocPixels throw on failure (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/images/SkImageDecoder.cpp

diff --git a/src/images/SkImageDecoder.cpp b/src/images/SkImageDecoder.cpp

index ed2ad164a11aea72d8b171b42c084fb813eeb1aa..4a5e734628c213072981fdbbc850b6a01f13d932 100644

--- a/src/images/SkImageDecoder.cpp

+++ b/src/images/SkImageDecoder.cpp

@@ -133,7 +133,7 @@ bool SkImageDecoder::chooseFromOneChoice(SkColorType colorType, int width, int h

bool SkImageDecoder::allocPixelRef(SkBitmap* bitmap,

SkColorTable* ctable) const {

- return bitmap->allocPixels(fAllocator, ctable);

+ return bitmap->tryAllocPixels(fAllocator, ctable);

}

///////////////////////////////////////////////////////////////////////////////

« no previous file with comments | « src/images/SkDecodingImageGenerator.cpp ('k') | src/images/SkImageDecoder_libjpeg.cpp » ('j') | no next file with comments »