src/images/SkDecodingImageGenerator.cpp - Issue 510423005: make allocPixels throw on failure

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/images/SkDecodingImageGenerator.cpp

Issue 510423005: make allocPixels throw on failure (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/images/SkDecodingImageGenerator.cpp

diff --git a/src/images/SkDecodingImageGenerator.cpp b/src/images/SkDecodingImageGenerator.cpp

index dfa093becc5d5ff7162727729d04e175fe1d18f0..5c66c94a534e257d01d09d2f0a7bbe595de96bfa 100644

--- a/src/images/SkDecodingImageGenerator.cpp

+++ b/src/images/SkDecodingImageGenerator.cpp

@@ -69,7 +69,7 @@ public:

virtual bool allocPixelRef(SkBitmap* bm, SkColorTable* ct) {

if (NULL == fTarget || !equal_modulo_alpha(fInfo, bm->info())) {

// Call default allocator.

- return bm->allocPixels(NULL, ct);

+ return bm->tryAllocPixels(NULL, ct);

}

// TODO(halcanary): verify that all callers of this function

« no previous file with comments | « src/image/SkImage.cpp ('k') | src/images/SkImageDecoder.cpp » ('j') | no next file with comments »