src/pdf/SkPDFDevice.cpp - Issue 510423005: make allocPixels throw on failure

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/pdf/SkPDFDevice.cpp

Issue 510423005: make allocPixels throw on failure (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: can't use (void) to suppress the "must check return result" Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/pdf/SkPDFDevice.cpp

diff --git a/src/pdf/SkPDFDevice.cpp b/src/pdf/SkPDFDevice.cpp

index ec07a8ff0ed42b8872fb78bdbd3296632180b84a..f4ea694451d93433c797aeae6f8be78b11b10bd0 100644

--- a/src/pdf/SkPDFDevice.cpp

+++ b/src/pdf/SkPDFDevice.cpp

@@ -2120,7 +2120,7 @@ void SkPDFDevice::internalDrawBitmap(const SkMatrix& origMatrix,

const int w = SkScalarCeilToInt(physicalPerspectiveOutline.getBounds().width());

const int h = SkScalarCeilToInt(physicalPerspectiveOutline.getBounds().height());

- if (!perspectiveBitmap.allocPixels(SkImageInfo::MakeN32Premul(w, h))) {

+ if (!perspectiveBitmap.tryAllocN32Pixels(w, h)) {

return;

}

perspectiveBitmap.eraseColor(SK_ColorTRANSPARENT);