src/lazy/SkDiscardablePixelRef.cpp - Issue 510423005: make allocPixels throw on failure

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/lazy/SkDiscardablePixelRef.cpp

Issue 510423005: make allocPixels throw on failure (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: can't use (void) to suppress the "must check return result" Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/lazy/SkDiscardablePixelRef.cpp

diff --git a/src/lazy/SkDiscardablePixelRef.cpp b/src/lazy/SkDiscardablePixelRef.cpp

index a86c3deff426a07c548cec81a3325f294e23e6d2..ec8d5ea9afeb13f6f672c1aef02df2ddf7f0b502 100644

--- a/src/lazy/SkDiscardablePixelRef.cpp

+++ b/src/lazy/SkDiscardablePixelRef.cpp

@@ -110,7 +110,7 @@ bool SkInstallDiscardablePixelRef(SkImageGenerator* generator, SkBitmap* dst,

SkASSERT(info.colorType() != kUnknown_SkColorType);

if (dst->empty()) { // Use a normal pixelref.

- return dst->allocPixels();

+ return dst->tryAllocPixels();

}

SkAutoTUnref<SkDiscardablePixelRef> ref(

SkNEW_ARGS(SkDiscardablePixelRef,