Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 510183002: Fix ExtensionOptionsGuest style and minor bug (Closed)

Created:
6 years, 3 months ago by ericzeng
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix ExtensionOptionsGuest style and minor bug - Reorganize methods in cc file so they match up with the header - In SetUpAutoSize, use the autosize flag parameter read in from the embedder to enable/disable autosize instead of passing true BUG=386838 Committed: https://crrev.com/e9b8e2e2cd87d9356a3ef5834f394f512f888056 Cr-Commit-Position: refs/heads/master@{#292629}

Patch Set 1 #

Patch Set 2 : Fix autosize parameter in extension_options.js #

Patch Set 3 : Rebase #

Patch Set 4 : Fix rebase error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -43 lines) Patch
M chrome/browser/guest_view/extension_options/extension_options_guest.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/guest_view/extension_options/extension_options_guest.cc View 1 2 3 chunks +42 lines, -41 lines 0 comments Download
M chrome/renderer/resources/extensions/extension_options.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 22 (0 generated)
ericzeng
ericzeng@chromium.org changed reviewers: + fsamuel@chromium.org
6 years, 3 months ago (2014-08-27 23:34:43 UTC) #1
ericzeng
PTAL, this CL is to fix that one line in ExtensionOptionsGuest where I enabled autosize ...
6 years, 3 months ago (2014-08-27 23:34:43 UTC) #2
Fady Samuel
lgtm
6 years, 3 months ago (2014-08-27 23:37:24 UTC) #3
ericzeng
The CQ bit was checked by ericzeng@chromium.org
6 years, 3 months ago (2014-08-28 17:11:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ericzeng@chromium.org/510183002/50001
6 years, 3 months ago (2014-08-28 17:12:34 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-28 18:08:21 UTC) #6
ericzeng
The CQ bit was unchecked by ericzeng@chromium.org
6 years, 3 months ago (2014-08-28 18:09:18 UTC) #7
ericzeng
ericzeng@chromium.org changed reviewers: + kalman@chromium.org
6 years, 3 months ago (2014-08-28 18:10:29 UTC) #8
not at google - send to devlin
lgtm
6 years, 3 months ago (2014-08-28 18:19:34 UTC) #9
ericzeng
The CQ bit was checked by ericzeng@chromium.org
6 years, 3 months ago (2014-08-28 18:20:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ericzeng@chromium.org/510183002/50001
6 years, 3 months ago (2014-08-28 18:22:37 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel_swarming on tryserver.chromium.win ...
6 years, 3 months ago (2014-08-28 19:01:03 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-28 19:55:09 UTC) #13
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-08-28 19:55:10 UTC) #14
ericzeng
The CQ bit was checked by ericzeng@chromium.org
6 years, 3 months ago (2014-08-28 19:56:18 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ericzeng@chromium.org/510183002/50001
6 years, 3 months ago (2014-08-28 19:57:42 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-28 20:00:08 UTC) #17
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-08-28 20:00:09 UTC) #18
Fady Samuel
The CQ bit was checked by fsamuel@chromium.org
6 years, 3 months ago (2014-08-29 14:31:06 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ericzeng@chromium.org/510183002/50001
6 years, 3 months ago (2014-08-29 14:31:37 UTC) #20
commit-bot: I haz the power
Committed patchset #4 (id:50001) as 98d743e74b552f2884d9f1a103787def778b95c5
6 years, 3 months ago (2014-08-29 14:32:29 UTC) #21
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:08:30 UTC) #22
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/e9b8e2e2cd87d9356a3ef5834f394f512f888056
Cr-Commit-Position: refs/heads/master@{#292629}

Powered by Google App Engine
This is Rietveld 408576698