Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1413)

Unified Diff: chrome/browser/guest_view/extension_options/extension_options_guest.cc

Issue 510183002: Fix ExtensionOptionsGuest style and minor bug (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix rebase error Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/guest_view/extension_options/extension_options_guest.cc
diff --git a/chrome/browser/guest_view/extension_options/extension_options_guest.cc b/chrome/browser/guest_view/extension_options/extension_options_guest.cc
index 4a7a07ca1a7eaa1dcef72abcab58bd0dadade70b..9fc3c5d4c03f1cd882ed5bd3ef7ed1c9ebc938c6 100644
--- a/chrome/browser/guest_view/extension_options/extension_options_guest.cc
+++ b/chrome/browser/guest_view/extension_options/extension_options_guest.cc
@@ -135,25 +135,6 @@ int ExtensionOptionsGuest::GetTaskPrefix() const {
return IDS_EXTENSION_TASK_MANAGER_EXTENSIONOPTIONS_TAG_PREFIX;
}
-content::WebContents* ExtensionOptionsGuest::GetAssociatedWebContents() const {
- return guest_web_contents();
-}
-
-bool ExtensionOptionsGuest::OnMessageReceived(const IPC::Message& message) {
- bool handled = true;
- IPC_BEGIN_MESSAGE_MAP(ExtensionOptionsGuest, message)
- IPC_MESSAGE_HANDLER(ExtensionHostMsg_Request, OnRequest)
- IPC_MESSAGE_UNHANDLED(handled = false)
- IPC_END_MESSAGE_MAP()
- return handled;
-}
-
-void ExtensionOptionsGuest::OnRequest(
- const ExtensionHostMsg_Request_Params& params) {
- extension_function_dispatcher_->Dispatch(
- params, guest_web_contents()->GetRenderViewHost());
-}
-
void ExtensionOptionsGuest::GuestSizeChangedDueToAutoSize(
const gfx::Size& old_size,
const gfx::Size& new_size) {
@@ -170,28 +151,8 @@ bool ExtensionOptionsGuest::IsAutoSizeSupported() const {
return true;
}
-void ExtensionOptionsGuest::SetUpAutoSize() {
- // Read the autosize parameters passed in from the embedder.
- bool auto_size_enabled = false;
- attach_params()->GetBoolean(extensionoptions::kAttributeAutoSize,
- &auto_size_enabled);
-
- int max_height = 0;
- int max_width = 0;
- attach_params()->GetInteger(extensionoptions::kAttributeMaxHeight,
- &max_height);
- attach_params()->GetInteger(extensionoptions::kAttributeMaxWidth, &max_width);
-
- int min_height = 0;
- int min_width = 0;
- attach_params()->GetInteger(extensionoptions::kAttributeMinHeight,
- &min_height);
- attach_params()->GetInteger(extensionoptions::kAttributeMinWidth, &min_width);
-
- // Call SetAutoSize to apply all the appropriate validation and clipping of
- // values.
- SetAutoSize(
- true, gfx::Size(min_width, min_height), gfx::Size(max_width, max_height));
+content::WebContents* ExtensionOptionsGuest::GetAssociatedWebContents() const {
+ return guest_web_contents();
}
void ExtensionOptionsGuest::CloseContents(content::WebContents* source) {
@@ -237,3 +198,43 @@ bool ExtensionOptionsGuest::ShouldCreateWebContents(
// ctrl-click or middle mouse button click
return false;
}
+
+bool ExtensionOptionsGuest::OnMessageReceived(const IPC::Message& message) {
+ bool handled = true;
+ IPC_BEGIN_MESSAGE_MAP(ExtensionOptionsGuest, message)
+ IPC_MESSAGE_HANDLER(ExtensionHostMsg_Request, OnRequest)
+ IPC_MESSAGE_UNHANDLED(handled = false)
+ IPC_END_MESSAGE_MAP()
+ return handled;
+}
+
+void ExtensionOptionsGuest::OnRequest(
+ const ExtensionHostMsg_Request_Params& params) {
+ extension_function_dispatcher_->Dispatch(
+ params, guest_web_contents()->GetRenderViewHost());
+}
+
+void ExtensionOptionsGuest::SetUpAutoSize() {
+ // Read the autosize parameters passed in from the embedder.
+ bool auto_size_enabled = false;
+ attach_params()->GetBoolean(extensionoptions::kAttributeAutoSize,
+ &auto_size_enabled);
+
+ int max_height = 0;
+ int max_width = 0;
+ attach_params()->GetInteger(extensionoptions::kAttributeMaxHeight,
+ &max_height);
+ attach_params()->GetInteger(extensionoptions::kAttributeMaxWidth, &max_width);
+
+ int min_height = 0;
+ int min_width = 0;
+ attach_params()->GetInteger(extensionoptions::kAttributeMinHeight,
+ &min_height);
+ attach_params()->GetInteger(extensionoptions::kAttributeMinWidth, &min_width);
+
+ // Call SetAutoSize to apply all the appropriate validation and clipping of
+ // values.
+ SetAutoSize(auto_size_enabled,
+ gfx::Size(min_width, min_height),
+ gfx::Size(max_width, max_height));
+}

Powered by Google App Engine
This is Rietveld 408576698