LayoutTests/fast/multicol/vertical-lr/balancing/balance-short-trailing-empty-block.html - Issue 510123002: Make vertical-lr and vertical-rl versions of the tests that replace border-padding-pagination.html

Unified Diff: LayoutTests/fast/multicol/vertical-lr/balancing/balance-short-trailing-empty-block.html

Issue 510123002: Make vertical-lr and vertical-rl versions of the tests that replace border-padding-pagination.html (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/TestExpectations ('k') | LayoutTests/fast/multicol/vertical-lr/balancing/balance-short-trailing-empty-block-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/multicol/vertical-lr/balancing/balance-short-trailing-empty-block.html

diff --git a/LayoutTests/fast/multicol/vertical-lr/balancing/balance-short-trailing-empty-block.html b/LayoutTests/fast/multicol/vertical-lr/balancing/balance-short-trailing-empty-block.html

new file mode 100644

index 0000000000000000000000000000000000000000..4e4e1a900c87ef7242c4dd54a41b7f253dd6d6c5

--- /dev/null

+++ b/LayoutTests/fast/multicol/vertical-lr/balancing/balance-short-trailing-empty-block.html

@@ -0,0 +1,13 @@

+<!DOCTYPE html>

+<script src="../../../../resources/js-test.js"></script>

+<p>Both words below should be in the the right column.</p>

+<div id="console"></div>

+<div id="mc" style="-webkit-writing-mode:vertical-lr; -webkit-columns:2; columns:2; orphans:1; widows:1; -webkit-column-rule:1px solid; column-rule:1px solid; background:olive;">

Julien - ping for review 2014/09/05 01:45:14 I don't think the widows / orphans rules are requi

mstensho (USE GERRIT) 2014/09/05 07:46:58 The initial value of widows and orphans are implem

Julien - ping for review 2014/09/05 19:53:09 Fair point. I am fine with keeping them then.

+ <div style="width:120px;"></div>

+ <div style="line-height:80px;">second<br>column</div>

+ <div style="width:30px;"></div>

+</div>

+<script>

+ description("Tests that a block a column boundary is recorded properly for balancing");

Julien - ping for review 2014/09/05 01:45:14 Not sure I parse this sentence correctly.

mstensho (USE GERRIT) 2014/09/05 07:46:58 Not sure there is a way. :) This was copied from .

+ shouldBe("mc.offsetWidth", "190");

+</script>