LayoutTests/fast/multicol/vertical-lr/balancing/balance-short-trailing-empty-block.html - Issue 510123002: Make vertical-lr and vertical-rl versions of the tests that replace border-padding-pagination.html

Side by Side Diff: LayoutTests/fast/multicol/vertical-lr/balancing/balance-short-trailing-empty-block.html

Issue 510123002: Make vertical-lr and vertical-rl versions of the tests that replace border-padding-pagination.html (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/TestExpectations ('k') | LayoutTests/fast/multicol/vertical-lr/balancing/balance-short-trailing-empty-block-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../../../resources/js-test.js"></script>

	3 <p>Both words below should be in the the right column.</p>

	4 <div id="console"></div>

	5 <div id="mc" style="-webkit-writing-mode:vertical-lr; -webkit-columns:2; columns :2; orphans:1; widows:1; -webkit-column-rule:1px solid; column-rule:1px solid; b ackground:olive;">
	Julien - ping for review 2014/09/05 01:45:14 I don't think the widows / orphans rules are requi I don't think the widows / orphans rules are required (and they had a lot of complexity that I find unneeded as they are _not_ what we are trying to test). mstensho (USE GERRIT) 2014/09/05 07:46:58 The initial value of widows and orphans are implem Show quoted text On 2014/09/05 01:45:14, Julien Chaffraix - PST wrote: > I don't think the widows / orphans rules are required (and they had a lot of > complexity that I find unneeded as they are _not_ what we are trying to test). The initial value of widows and orphans are implemented incorrectly in Blink (should be '2' - is 'auto', which isn't even a valid value, according to the spec), so yes, I could remove them, provided that nobody ever fixes the initial value thing. But if widows and orphans actually were 2 in this test, it might "incorrectly" pass beacause of that, and not because of correct balancing (which is what I want to test). I think it was a bad decision to spec it like this (should initially be 1, in my opinion), but that's a different discussion, that I should have taken 20 years ago. :) Julien - ping for review 2014/09/05 19:53:09 Fair point. I am fine with keeping them then. Show quoted text On 2014/09/05 07:46:58, mstensho wrote: > On 2014/09/05 01:45:14, Julien Chaffraix - PST wrote: > > I don't think the widows / orphans rules are required (and they had a lot of > > complexity that I find unneeded as they are _not_ what we are trying to test). > > The initial value of widows and orphans are implemented incorrectly in Blink > (should be '2' - is 'auto', which isn't even a valid value, according to the > spec), so yes, I could remove them, provided that nobody ever fixes the initial > value thing. But if widows and orphans actually were 2 in this test, it might > "incorrectly" pass beacause of that, and not because of correct balancing (which > is what I want to test). > > I think it was a bad decision to spec it like this (should initially be 1, in my > opinion), but that's a different discussion, that I should have taken 20 years > ago. :) Fair point. I am fine with keeping them then.
	6 <div style="width:120px;"></div>

	7 <div style="line-height:80px;">second<br>column</div>

	8 <div style="width:30px;"></div>

	9 </div>

	10 <script>

	11 description("Tests that a block a column boundary is recorded properly for b alancing");
	Julien - ping for review 2014/09/05 01:45:14 Not sure I parse this sentence correctly. Not sure I parse this sentence correctly. mstensho (USE GERRIT) 2014/09/05 07:46:58 Not sure there is a way. :) This was copied from . Show quoted text On 2014/09/05 01:45:14, Julien Chaffraix - PST wrote: > Not sure I parse this sentence correctly. Not sure there is a way. :) This was copied from ../../balance-short-trailing-empty-block.html , so I'll fix it there too. Done.
	12 shouldBe("mc.offsetWidth", "190");

	13 </script>

OLD	NEW