Make vertical-lr and vertical-rl versions of the tests that replace border-padding-pagination.html

Make vertical-lr and vertical-rl versions of the tests that replace border-padding-pagination.html

border-padding-pagination.html exists for both these writing modes, and it won't be
used in the new implementation, so better make sure that we don't lose coverage.

R=jchaffraix@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181622

[Julien - ping for review, 2014-09-05 01:45:14]

I am not sure I understand why we need to split the existing testing, especially
since fast/multicol/border-padding-pagination.html has a comment about being
superseeded in the region based implementation.

https://codereview.chromium.org/510123002/diff/1/LayoutTests/fast/multicol/ve...
File
LayoutTests/fast/multicol/vertical-lr/balancing/balance-short-trailing-empty-block.html
(right):

https://codereview.chromium.org/510123002/diff/1/LayoutTests/fast/multicol/ve...
LayoutTests/fast/multicol/vertical-lr/balancing/balance-short-trailing-empty-block.html:5:
<div id="mc" style="-webkit-writing-mode:vertical-lr; -webkit-columns:2;
columns:2; orphans:1; widows:1; -webkit-column-rule:1px solid; column-rule:1px
solid; background:olive;">
I don't think the widows / orphans rules are required (and they had a lot of
complexity that I find unneeded as they are _not_ what we are trying to test).

https://codereview.chromium.org/510123002/diff/1/LayoutTests/fast/multicol/ve...
LayoutTests/fast/multicol/vertical-lr/balancing/balance-short-trailing-empty-block.html:11:
description("Tests that a block a column boundary is recorded properly for
balancing");
Not sure I parse this sentence correctly.

[mstensho (USE GERRIT), 2014-09-05 07:46:41]

On 2014/09/05 01:45:14, Julien Chaffraix - PST wrote:
> I am not sure I understand why we need to split the existing testing,
especially
> since fast/multicol/border-padding-pagination.html has a comment about being
> superseeded in the region based implementation.

There's already a version of border-padding-pagination.html in both vertical-lr/
and vertical-rl/ . They should eventually be removed too, and this patch
provides the replacements. I've added the "deprecation note" to those two
border-padding-pagination.html tests as well now.

[mstensho (USE GERRIT), 2014-09-05 07:46:58]

https://codereview.chromium.org/510123002/diff/1/LayoutTests/fast/multicol/ve...
File
LayoutTests/fast/multicol/vertical-lr/balancing/balance-short-trailing-empty-block.html
(right):

https://codereview.chromium.org/510123002/diff/1/LayoutTests/fast/multicol/ve...
LayoutTests/fast/multicol/vertical-lr/balancing/balance-short-trailing-empty-block.html:5:
<div id="mc" style="-webkit-writing-mode:vertical-lr; -webkit-columns:2;
columns:2; orphans:1; widows:1; -webkit-column-rule:1px solid; column-rule:1px
solid; background:olive;">
On 2014/09/05 01:45:14, Julien Chaffraix - PST wrote:
> I don't think the widows / orphans rules are required (and they had a lot of
> complexity that I find unneeded as they are _not_ what we are trying to test).

The initial value of widows and orphans are implemented incorrectly in Blink
(should be '2' - is 'auto', which isn't even a valid value, according to the
spec), so yes, I could remove them, provided that nobody ever fixes the initial
value thing. But if widows and orphans actually were 2 in this test, it might
"incorrectly" pass beacause of that, and not because of correct balancing (which
is what I want to test).

I think it was a bad decision to spec it like this (should initially be 1, in my
opinion), but that's a different discussion, that I should have taken 20 years
ago. :)

https://codereview.chromium.org/510123002/diff/1/LayoutTests/fast/multicol/ve...
LayoutTests/fast/multicol/vertical-lr/balancing/balance-short-trailing-empty-block.html:11:
description("Tests that a block a column boundary is recorded properly for
balancing");
On 2014/09/05 01:45:14, Julien Chaffraix - PST wrote:
> Not sure I parse this sentence correctly.

Not sure there is a way. :) This was copied from
../../balance-short-trailing-empty-block.html , so I'll fix it there too.

Done.

[Julien - ping for review, 2014-09-05 19:53:09]

lgtm, thanks for the explanation.

https://codereview.chromium.org/510123002/diff/1/LayoutTests/fast/multicol/ve...
File
LayoutTests/fast/multicol/vertical-lr/balancing/balance-short-trailing-empty-block.html
(right):

https://codereview.chromium.org/510123002/diff/1/LayoutTests/fast/multicol/ve...
LayoutTests/fast/multicol/vertical-lr/balancing/balance-short-trailing-empty-block.html:5:
<div id="mc" style="-webkit-writing-mode:vertical-lr; -webkit-columns:2;
columns:2; orphans:1; widows:1; -webkit-column-rule:1px solid; column-rule:1px
solid; background:olive;">
On 2014/09/05 07:46:58, mstensho wrote:
> On 2014/09/05 01:45:14, Julien Chaffraix - PST wrote:
> > I don't think the widows / orphans rules are required (and they had a lot of
> > complexity that I find unneeded as they are _not_ what we are trying to
test).
> 
> The initial value of widows and orphans are implemented incorrectly in Blink
> (should be '2' - is 'auto', which isn't even a valid value, according to the
> spec), so yes, I could remove them, provided that nobody ever fixes the
initial
> value thing. But if widows and orphans actually were 2 in this test, it might
> "incorrectly" pass beacause of that, and not because of correct balancing
(which
> is what I want to test).
> 
> I think it was a bad decision to spec it like this (should initially be 1, in
my
> opinion), but that's a different discussion, that I should have taken 20 years
> ago. :)

Fair point. I am fine with keeping them then.

https://codereview.chromium.org/510123002/diff/40001/LayoutTests/fast/multico...
File
LayoutTests/fast/multicol/vertical-lr/balancing/balance-trailing-border2.html
(right):

https://codereview.chromium.org/510123002/diff/40001/LayoutTests/fast/multico...
LayoutTests/fast/multicol/vertical-lr/balancing/balance-trailing-border2.html:1:
<!DOCTYPE html>
Let's put a more meaningful name than border2 :)

https://codereview.chromium.org/510123002/diff/40001/LayoutTests/fast/multico...
File
LayoutTests/fast/multicol/vertical-rl/balancing/balance-trailing-border2.html
(right):

https://codereview.chromium.org/510123002/diff/40001/LayoutTests/fast/multico...
LayoutTests/fast/multicol/vertical-rl/balancing/balance-trailing-border2.html:1:
<!DOCTYPE html>
Same comment.

[mstensho (USE GERRIT), 2014-09-09 07:45:16]

https://codereview.chromium.org/510123002/diff/40001/LayoutTests/fast/multico...
File
LayoutTests/fast/multicol/vertical-lr/balancing/balance-trailing-border2.html
(right):

https://codereview.chromium.org/510123002/diff/40001/LayoutTests/fast/multico...
LayoutTests/fast/multicol/vertical-lr/balancing/balance-trailing-border2.html:1:
<!DOCTYPE html>
On 2014/09/05 19:53:09, Julien Chaffraix - PST wrote:
> Let's put a more meaningful name than border2 :)

Done.

https://codereview.chromium.org/510123002/diff/40001/LayoutTests/fast/multico...
File
LayoutTests/fast/multicol/vertical-rl/balancing/balance-trailing-border2.html
(right):

https://codereview.chromium.org/510123002/diff/40001/LayoutTests/fast/multico...
LayoutTests/fast/multicol/vertical-rl/balancing/balance-trailing-border2.html:1:
<!DOCTYPE html>
On 2014/09/05 19:53:09, Julien Chaffraix - PST wrote:
> Same comment.

Done.

[mstensho (USE GERRIT), 2014-09-09 07:45:26]

The CQ bit was checked by mstensho@opera.com

[commit-bot: I haz the power, 2014-09-09 07:46:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mstensho@opera.com/510123002/60001

[commit-bot: I haz the power, 2014-09-09 08:49:06]

Committed patchset #4 (id:60001) as 181622