Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1928)

Issue 509713002: ozone: evdev: Fix TouchEvent radius (Closed)

Created:
6 years, 3 months ago by spang
Modified:
6 years, 3 months ago
CC:
chromium-reviews, rjkroege, kalyank, tdresser+watch_chromium.org, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

ozone: evdev: Fix TouchEvent radius We get the touch ellipse geometry from the major/minor/orientation axis of the MT protocol. Use those intead of attempting to derive it from pressure. BUG=381898 TEST=chrome on pixel with --ash-touch-hud NOTRY=true Committed: https://crrev.com/4efef5c727d59a1f7e0468a47f55f6760ad7cfa2 Cr-Commit-Position: refs/heads/master@{#292323}

Patch Set 1 #

Total comments: 1

Patch Set 2 : pizels #

Patch Set 3 : add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -8 lines) Patch
M ui/events/ozone/evdev/touch_event_converter_evdev.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/events/ozone/evdev/touch_event_converter_evdev.cc View 1 2 4 chunks +16 lines, -7 lines 0 comments Download
M ui/events/ozone/evdev/touch_event_converter_evdev_unittest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
spang
spang@chromium.org changed reviewers: + alexst@chromium.org, miletus@chromium.org
6 years, 3 months ago (2014-08-26 22:20:43 UTC) #1
spang
6 years, 3 months ago (2014-08-26 22:20:43 UTC) #2
Yufeng Shen (Slow to review)
miletus@chromium.org changed reviewers: + sadrul@chromium.org
6 years, 3 months ago (2014-08-26 23:32:30 UTC) #3
alexst (slow to review)
lgtm pending other reviewers. https://codereview.chromium.org/509713002/diff/1/ui/events/ozone/evdev/touch_event_converter_evdev.cc File ui/events/ozone/evdev/touch_event_converter_evdev.cc (right): https://codereview.chromium.org/509713002/diff/1/ui/events/ozone/evdev/touch_event_converter_evdev.cc#newcode67 ui/events/ozone/evdev/touch_event_converter_evdev.cc:67: float TuxelToPizelSize(float val, float num_tuxels, ...
6 years, 3 months ago (2014-08-26 23:51:26 UTC) #4
spang
The CQ bit was checked by spang@chromium.org
6 years, 3 months ago (2014-08-27 05:28:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/509713002/20001
6 years, 3 months ago (2014-08-27 05:29:08 UTC) #6
spang
The CQ bit was unchecked by spang@chromium.org
6 years, 3 months ago (2014-08-27 05:30:20 UTC) #7
spang
The CQ bit was checked by spang@chromium.org
6 years, 3 months ago (2014-08-28 05:13:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/509713002/40001
6 years, 3 months ago (2014-08-28 05:14:27 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 38afdbc0465716748dd50c7c90592cf1f4b623d4
6 years, 3 months ago (2014-08-28 05:29:13 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:57:37 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4efef5c727d59a1f7e0468a47f55f6760ad7cfa2
Cr-Commit-Position: refs/heads/master@{#292323}

Powered by Google App Engine
This is Rietveld 408576698