net/ssl/ssl_client_auth_cache_unittest.cc - Issue 509563003: Remove implicit conversions from scoped_refptr to T* in net/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/ssl/ssl_client_auth_cache_unittest.cc

Issue 509563003: Remove implicit conversions from scoped_refptr to T* in net/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/ssl/ssl_client_auth_cache_unittest.cc

diff --git a/net/ssl/ssl_client_auth_cache_unittest.cc b/net/ssl/ssl_client_auth_cache_unittest.cc

index 284fb46eda86a329ff2addb06f5669df5ed4458d..567418a3fb451076fc1e3baadc47c7535ced70ff 100644

--- a/net/ssl/ssl_client_auth_cache_unittest.cc

+++ b/net/ssl/ssl_client_auth_cache_unittest.cc

@@ -43,7 +43,7 @@ TEST(SSLClientAuthCacheTest, LookupAddRemove) {

cache.Add(server2, cert2.get());

cached_cert = NULL;

EXPECT_TRUE(cache.Lookup(server1, &cached_cert));

- EXPECT_EQ(cert1, cached_cert.get());

+ EXPECT_EQ(cert1.get(), cached_cert.get());

cached_cert = NULL;

EXPECT_TRUE(cache.Lookup(server2, &cached_cert));

EXPECT_EQ(cert2, cached_cert);

@@ -95,9 +95,9 @@ TEST(SSLClientAuthCacheTest, LookupWithPort) {

scoped_refptr<X509Certificate> cached_cert;

EXPECT_TRUE(cache.Lookup(server1, &cached_cert));

- EXPECT_EQ(cert1.get(), cached_cert);

+ EXPECT_EQ(cert1.get(), cached_cert.get());

EXPECT_TRUE(cache.Lookup(server2, &cached_cert));

- EXPECT_EQ(cert2.get(), cached_cert);

+ EXPECT_EQ(cert2.get(), cached_cert.get());

}

// Check that the a NULL certificate, indicating the user has declined to send

« no previous file with comments | « net/spdy/spdy_session_unittest.cc ('k') | net/test/cert_test_util_nss.cc » ('j') | no next file with comments »