Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Side by Side Diff: net/ssl/ssl_client_auth_cache_unittest.cc

Issue 509563003: Remove implicit conversions from scoped_refptr to T* in net/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/spdy/spdy_session_unittest.cc ('k') | net/test/cert_test_util_nss.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/ssl/ssl_client_auth_cache.h" 5 #include "net/ssl/ssl_client_auth_cache.h"
6 6
7 #include "base/time/time.h" 7 #include "base/time/time.h"
8 #include "net/cert/x509_certificate.h" 8 #include "net/cert/x509_certificate.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 10
(...skipping 25 matching lines...) Expand all
36 // Add client certificate for server1. 36 // Add client certificate for server1.
37 cache.Add(server1, cert1.get()); 37 cache.Add(server1, cert1.get());
38 cached_cert = NULL; 38 cached_cert = NULL;
39 EXPECT_TRUE(cache.Lookup(server1, &cached_cert)); 39 EXPECT_TRUE(cache.Lookup(server1, &cached_cert));
40 EXPECT_EQ(cert1, cached_cert); 40 EXPECT_EQ(cert1, cached_cert);
41 41
42 // Add client certificate for server2. 42 // Add client certificate for server2.
43 cache.Add(server2, cert2.get()); 43 cache.Add(server2, cert2.get());
44 cached_cert = NULL; 44 cached_cert = NULL;
45 EXPECT_TRUE(cache.Lookup(server1, &cached_cert)); 45 EXPECT_TRUE(cache.Lookup(server1, &cached_cert));
46 EXPECT_EQ(cert1, cached_cert.get()); 46 EXPECT_EQ(cert1.get(), cached_cert.get());
47 cached_cert = NULL; 47 cached_cert = NULL;
48 EXPECT_TRUE(cache.Lookup(server2, &cached_cert)); 48 EXPECT_TRUE(cache.Lookup(server2, &cached_cert));
49 EXPECT_EQ(cert2, cached_cert); 49 EXPECT_EQ(cert2, cached_cert);
50 50
51 // Overwrite the client certificate for server1. 51 // Overwrite the client certificate for server1.
52 cache.Add(server1, cert3.get()); 52 cache.Add(server1, cert3.get());
53 cached_cert = NULL; 53 cached_cert = NULL;
54 EXPECT_TRUE(cache.Lookup(server1, &cached_cert)); 54 EXPECT_TRUE(cache.Lookup(server1, &cached_cert));
55 EXPECT_EQ(cert3, cached_cert); 55 EXPECT_EQ(cert3, cached_cert);
56 cached_cert = NULL; 56 cached_cert = NULL;
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 88
89 HostPortPair server2("foo", 8443); 89 HostPortPair server2("foo", 8443);
90 scoped_refptr<X509Certificate> cert2( 90 scoped_refptr<X509Certificate> cert2(
91 new X509Certificate("foo", "CA", start_date, expiration_date)); 91 new X509Certificate("foo", "CA", start_date, expiration_date));
92 92
93 cache.Add(server1, cert1.get()); 93 cache.Add(server1, cert1.get());
94 cache.Add(server2, cert2.get()); 94 cache.Add(server2, cert2.get());
95 95
96 scoped_refptr<X509Certificate> cached_cert; 96 scoped_refptr<X509Certificate> cached_cert;
97 EXPECT_TRUE(cache.Lookup(server1, &cached_cert)); 97 EXPECT_TRUE(cache.Lookup(server1, &cached_cert));
98 EXPECT_EQ(cert1.get(), cached_cert); 98 EXPECT_EQ(cert1.get(), cached_cert.get());
99 EXPECT_TRUE(cache.Lookup(server2, &cached_cert)); 99 EXPECT_TRUE(cache.Lookup(server2, &cached_cert));
100 EXPECT_EQ(cert2.get(), cached_cert); 100 EXPECT_EQ(cert2.get(), cached_cert.get());
101 } 101 }
102 102
103 // Check that the a NULL certificate, indicating the user has declined to send 103 // Check that the a NULL certificate, indicating the user has declined to send
104 // a certificate, is properly cached. 104 // a certificate, is properly cached.
105 TEST(SSLClientAuthCacheTest, LookupNullPreference) { 105 TEST(SSLClientAuthCacheTest, LookupNullPreference) {
106 SSLClientAuthCache cache; 106 SSLClientAuthCache cache;
107 base::Time start_date = base::Time::Now(); 107 base::Time start_date = base::Time::Now();
108 base::Time expiration_date = start_date + base::TimeDelta::FromDays(1); 108 base::Time expiration_date = start_date + base::TimeDelta::FromDays(1);
109 109
110 HostPortPair server1("foo", 443); 110 HostPortPair server1("foo", 443);
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
162 EXPECT_EQ(NULL, cached_cert.get()); 162 EXPECT_EQ(NULL, cached_cert.get());
163 163
164 cache.OnCertAdded(NULL); 164 cache.OnCertAdded(NULL);
165 165
166 // Check that we no longer have entries for either server. 166 // Check that we no longer have entries for either server.
167 EXPECT_FALSE(cache.Lookup(server1, &cached_cert)); 167 EXPECT_FALSE(cache.Lookup(server1, &cached_cert));
168 EXPECT_FALSE(cache.Lookup(server2, &cached_cert)); 168 EXPECT_FALSE(cache.Lookup(server2, &cached_cert));
169 } 169 }
170 170
171 } // namespace net 171 } // namespace net
OLDNEW
« no previous file with comments | « net/spdy/spdy_session_unittest.cc ('k') | net/test/cert_test_util_nss.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698