Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 509563003: Remove implicit conversions from scoped_refptr to T* in net/ (Closed)

Created:
6 years, 3 months ago by dcheng
Modified:
6 years, 3 months ago
Reviewers:
Ryan Sleevi
CC:
cbentzel+watch_chromium.org, chromium-reviews, mmenke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove implicit conversions from scoped_refptr to T* in net/ This patch was generated by running the rewrite_scoped_refptr clang tool on a Linux build. BUG=110610 Committed: https://crrev.com/c80fed2a69da4b3a2d29104cae957f88e455b888 Cr-Commit-Position: refs/heads/master@{#292233}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -32 lines) Patch
M net/base/file_stream_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/sdch_manager_unittest.cc View 7 chunks +9 lines, -9 lines 0 comments Download
M net/base/upload_file_element_reader.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M net/dns/mdns_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/dns/mock_host_resolver.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/filter/sdch_filter.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/server/http_server_unittest.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M net/socket_stream/socket_stream.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/spdy/spdy_session_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/ssl/ssl_client_auth_cache_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/test/cert_test_util_nss.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/crl_set_dump/crl_set_dump.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
dcheng
dcheng@chromium.org changed reviewers: + rsleevi@chromium.org
6 years, 3 months ago (2014-08-26 23:14:44 UTC) #1
dcheng
You get to join the lg fun too! === begin copy and paste blurb === ...
6 years, 3 months ago (2014-08-26 23:14:44 UTC) #2
Ryan Sleevi
lgtm
6 years, 3 months ago (2014-08-27 18:52:19 UTC) #3
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 3 months ago (2014-08-27 18:53:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/509563003/1
6 years, 3 months ago (2014-08-27 18:54:08 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-27 20:23:43 UTC) #6
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-08-27 20:23:44 UTC) #7
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 3 months ago (2014-08-27 20:26:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/509563003/1
6 years, 3 months ago (2014-08-27 20:27:34 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-27 20:28:50 UTC) #10
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-08-27 20:28:50 UTC) #11
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 3 months ago (2014-08-27 20:30:30 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/509563003/1
6 years, 3 months ago (2014-08-27 20:32:10 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-27 20:33:35 UTC) #14
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-08-27 20:33:36 UTC) #15
dcheng
The CQ bit was checked by dcheng@chromium.org
6 years, 3 months ago (2014-08-27 21:43:42 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/509563003/1
6 years, 3 months ago (2014-08-27 21:45:20 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1) as ecafa8ea65284276f3fcc0912bf109cd5d44da9d
6 years, 3 months ago (2014-08-27 21:47:55 UTC) #18
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:54:24 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c80fed2a69da4b3a2d29104cae957f88e455b888
Cr-Commit-Position: refs/heads/master@{#292233}

Powered by Google App Engine
This is Rietveld 408576698