Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3302)

Unified Diff: chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm

Issue 50943002: Fix for UI issue with content settings icons displayed in the wrong order [cocoa] (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
diff --git a/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm b/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
index 51dc0e9d60bad73cbb35113c8a18e1e0dffbe479..f47847b26df4dc81f4204cc77f52216c4a953a42 100644
--- a/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
+++ b/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm
@@ -353,9 +353,9 @@ void LocationBarViewMac::Layout() {
// Iterate through |content_setting_decorations_| in reverse order so that
// the order in which the decorations are drawn matches the Views code.
- for (ScopedVector<ContentSettingDecoration>::reverse_iterator i =
- content_setting_decorations_.rbegin();
- i != content_setting_decorations_.rend(); ++i) {
+ for (ScopedVector<ContentSettingDecoration>::iterator i =
+ content_setting_decorations_.begin();
Ilya Sherman 2013/10/29 20:48:09 nit: As long as you're updating this loop, mind in
+ i != content_setting_decorations_.end(); ++i) {
[cell addRightDecoration:*i];
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698