Fix for UI issue with content settings icons displayed in the wrong order [cocoa]

chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/message_loop/message_loop.h"
 #include "base/prefs/pref_service.h"
@@ skipping 335 matching lines @@
   [cell addRightDecoration:star_decoration_.get()];
   [cell addRightDecoration:zoom_decoration_.get()];
 
   // Note that display order is right to left.
   for (size_t i = 0; i < page_action_decorations_.size(); ++i) {
     [cell addRightDecoration:page_action_decorations_[i]];
   }
 
   // Iterate through |content_setting_decorations_| in reverse order so that
   // the order in which the decorations are drawn matches the Views code.
-  for (ScopedVector<ContentSettingDecoration>::reverse_iterator i =
-       content_setting_decorations_.rbegin();
-       i != content_setting_decorations_.rend(); ++i) {
+  for (ScopedVector<ContentSettingDecoration>::iterator i =
+       content_setting_decorations_.begin();

[Ilya Sherman, 2013/10/29 20:48:09]

nit: As long as you're updating this loop, mind indenting this line four more
spaces, and changing the variable name to |it|?  Thanks.

+       i != content_setting_decorations_.end(); ++i) {
     [cell addRightDecoration:*i];
   }
 
   [cell addRightDecoration:keyword_hint_decoration_.get()];
   [cell addRightDecoration:mic_search_decoration_.get()];
 
   // By default only the location icon is visible.
   location_icon_decoration_->SetVisible(true);
   selected_keyword_decoration_->SetVisible(false);
   ev_bubble_decoration_->SetVisible(false);
@@ skipping 315 matching lines @@
 }
 
 bool LocationBarViewMac::UpdateMicSearchDecorationVisibility() {
   bool is_visible = !GetToolbarModel()->input_in_progress() &&
                     browser_->search_model()->voice_search_supported();
   if (mic_search_decoration_->IsVisible() == is_visible)
     return false;
   mic_search_decoration_->SetVisible(is_visible);
   return true;
 }