Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issue 50943002: Fix for UI issue with content settings icons displayed in the wrong order [cocoa] (Closed)

Created:
7 years, 1 month ago by npentrel
Modified:
7 years, 1 month ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, markusheintz_, vabr (Chromium)
Visibility:
Public.

Description

On Cocoa this is due to: https://codereview.chromium.org/23704009/ This can be counteracted by changing the reverse iterator to a normal iterator. BUG=312582 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231816

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 1 chunk +3 lines, -3 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
npentrel
Hi Ilya, Please have a look at this CL. It fixes a small bug. Thanks, ...
7 years, 1 month ago (2013-10-29 18:17:50 UTC) #1
Ilya Sherman
LGTM https://codereview.chromium.org/50943002/diff/1/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm File chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm (right): https://codereview.chromium.org/50943002/diff/1/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm#newcode357 chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm:357: content_setting_decorations_.begin(); nit: As long as you're updating this ...
7 years, 1 month ago (2013-10-29 20:48:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/npentrel@chromium.org/50943002/1
7 years, 1 month ago (2013-10-30 09:10:52 UTC) #3
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 1 month ago (2013-10-30 09:22:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/npentrel@chromium.org/50943002/1
7 years, 1 month ago (2013-10-30 10:49:34 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-10-30 12:01:57 UTC) #6
Message was sent while issue was closed.
Change committed as 231816

Powered by Google App Engine
This is Rietveld 408576698