Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 509423002: Printing fixups for scoped_refptr operator T* removal. (Closed)

Created:
6 years, 3 months ago by dcheng
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Printing fixups for scoped_refptr operator T* removal. BUG=110610 Committed: https://crrev.com/4739e4f3ed1991d6e5ae5aedf11ad42e860e86fc Cr-Commit-Position: refs/heads/master@{#293104}

Patch Set 1 #

Patch Set 2 : Moo #

Patch Set 3 : Fix compile error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M chrome/browser/local_discovery/service_discovery_shared_client.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/printing_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.cc View 1 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (3 generated)
dcheng
dcheng@chromium.org changed reviewers: + vitalybuka@chromium.org
6 years, 3 months ago (2014-08-28 17:54:20 UTC) #1
dcheng
Similar idea to https://codereview.chromium.org/513283002
6 years, 3 months ago (2014-08-28 17:54:20 UTC) #2
Vitaly Buka (NO REVIEWS)
lgtm
6 years, 3 months ago (2014-09-02 23:45:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/509423002/20001
6 years, 3 months ago (2014-09-03 00:03:21 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 3 months ago (2014-09-03 01:32:32 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/60452)
6 years, 3 months ago (2014-09-03 01:46:12 UTC) #8
dcheng
PTAL. I added a file in local_discovery to fix a compile error.
6 years, 3 months ago (2014-09-03 02:11:14 UTC) #9
Vitaly Buka (NO REVIEWS)
lgtm
6 years, 3 months ago (2014-09-03 08:13:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/509423002/40001
6 years, 3 months ago (2014-09-03 08:13:54 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001) as c8e1f375fbfd4749ba15fee2e92810a375485ccd
6 years, 3 months ago (2014-09-03 09:26:28 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:24:39 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4739e4f3ed1991d6e5ae5aedf11ad42e860e86fc
Cr-Commit-Position: refs/heads/master@{#293104}

Powered by Google App Engine
This is Rietveld 408576698