Issue 513283002: Local discovery fixups for scoped_refptr operator T* removal.

Issue 513283002: Local discovery fixups for scoped_refptr operator T* removal. (Closed)

Created:
6 years, 3 months ago by dcheng

Modified:
6 years, 3 months ago

Reviewers:
Vitaly Buka (NO REVIEWS)

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Local discovery fixups for scoped_refptr operator T* removal. BUG=110610 Committed: https://crrev.com/5bfa7b356a10a7960983468c4919df266b16cb00 Cr-Commit-Position: refs/heads/master@{#292436}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -3 lines)			Patch
M	chrome/browser/local_discovery/privet_http.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/local_discovery/privet_http_impl.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/local_discovery/privet_http_impl.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 7 (0 generated)

dcheng

dcheng@chromium.org changed reviewers: + vitalybuka@chromium.org

6 years, 3 months ago (2014-08-28 17:42:35 UTC) #1

dcheng

I've changed SetData() to just take a const scoped_refptr<T>& -- there were callers already passing ...

6 years, 3 months ago (2014-08-28 17:42:35 UTC) #2

Vitaly Buka (NO REVIEWS)

The CQ bit was checked by vitalybuka@chromium.org

6 years, 3 months ago (2014-08-28 17:53:07 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/513283002/1

6 years, 3 months ago (2014-08-28 17:53:20 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as 56cd7cc2d68a2f105dc38e77f53f605fb7888596

6 years, 3 months ago (2014-08-28 19:05:27 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 03:01:20 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/5bfa7b356a10a7960983468c4919df266b16cb00
Cr-Commit-Position: refs/heads/master@{#292436}