This is code readability patch, No Layout Test case needed

Use character names defined in CharacterNames.h.
This is code-readability patch. No layout tests are needed.

We were using character style Unicode in Blink, changed to
use Unicode present in CharacterNames.h

BUG=
R=eae@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181170

[h.joshi, 2014-08-28 13:11:33]

h.joshi@samsung.com changed reviewers:
+ behdad@chromium.org

[h.joshi, 2014-08-28 13:13:43]

@eae/behdad: While working on some other issue, found that we were using
character 
representation and not Unicode values (constant values defined in Blink).
This patch makes use of constant values where applicable.

[h.joshi, 2014-08-28 13:13:53]

PTAL

[eae, 2014-08-28 21:05:56]

Great change, thank you.

LGTM

[eae, 2014-08-28 21:06:00]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2014-08-28 21:06:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/h.joshi@samsung.com/509373002/1

[commit-bot: I haz the power, 2014-08-28 22:20:50]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/1...)

[commit-bot: I haz the power, 2014-08-28 22:25:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-28 22:25:59]

Try jobs failed on following builders:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/1...)

[h.joshi, 2014-08-29 01:37:29]

h.joshi@samsung.com changed reviewers:
+ tkent@chromium.org

[h.joshi, 2014-08-29 01:39:50]

#eae: Thank you

@tkent: Pls review this patch, in presubmit got following error:

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    Source/wtf/unicode/CharacterNames.h

[tkent, 2014-09-01 02:27:55]

> This is code readability patch, No Layout Test case needed
> We were using charater style unicode in Blink, changed to use Unicode
> present in CharacterNames.h

This CL description is not good.  Please write a short summary of the change at
the first line.  e.g.

-------------
Use character names defined in CharacterNames.h.

This is code-readability patch. No layout tests are needed.
-------------

https://codereview.chromium.org/509373002/diff/1/Source/wtf/unicode/Character...
File Source/wtf/unicode/CharacterNames.h (right):

https://codereview.chromium.org/509373002/diff/1/Source/wtf/unicode/Character...
Source/wtf/unicode/CharacterNames.h:91: const UChar tabCharacter = 0x0009;
Please insert this line to the sorted position.
Also, we should follow the standard name defined in Unicode.  0x0009 is
'CHARACTER TABULATION'.  See http://www.unicode.org/charts/charindex.html

[h.joshi, 2014-09-01 07:41:04]

@tkant: Made suggested changes, 
PTAL

[tkent, 2014-09-01 07:45:59]

https://codereview.chromium.org/509373002/diff/20001/Source/wtf/unicode/Chara...
File Source/wtf/unicode/CharacterNames.h (right):

https://codereview.chromium.org/509373002/diff/20001/Source/wtf/unicode/Chara...
Source/wtf/unicode/CharacterNames.h:79: const UChar tabulationCharacter =
0x0009;
As I wrote, U+0009 is 'CHARACTER TABULATION'.  So this symbol should be
characterTabulation.

[h.joshi, 2014-09-01 08:18:01]

Made changes, got "TABULATION, CHARACTER" also in the link shared so used that
in previous patch.
Pls review.

https://codereview.chromium.org/509373002/diff/20001/Source/wtf/unicode/Chara...
File Source/wtf/unicode/CharacterNames.h (right):

https://codereview.chromium.org/509373002/diff/20001/Source/wtf/unicode/Chara...
Source/wtf/unicode/CharacterNames.h:79: const UChar tabulationCharacter =
0x0009;
On 2014/09/01 07:45:59, tkent wrote:
> As I wrote, U+0009 is 'CHARACTER TABULATION'.  So this symbol should be
> characterTabulation.

Done.

[tkent, 2014-09-01 08:23:31]

On 2014/09/01 08:18:01, h.joshi wrote:
> Made changes, got "TABULATION, CHARACTER" also in the link shared so used that
> in previous patch.

Oh, I'm sorry that I overlooked the page had multiple entries for 0009.
lgtm

[tkent, 2014-09-01 08:23:35]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2014-09-01 08:23:52]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/h.joshi@samsung.com/509373002/60001

[commit-bot: I haz the power, 2014-09-01 09:30:15]

Committed patchset #4 (id:60001) as 181170