Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: Source/platform/fonts/FontFallbackList.cpp

Issue 509373002: This is code readability patch, No Layout Test case needed (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fixing order Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/rendering/RenderText.cpp ('k') | Source/platform/fonts/GlyphPageTreeNode.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/fonts/FontFallbackList.cpp
diff --git a/Source/platform/fonts/FontFallbackList.cpp b/Source/platform/fonts/FontFallbackList.cpp
index 16ef7a8c9e4c6af774a7176eb1d9911fab84e9bd..be38a01b2218e1716789d79e39fc13b505893500 100644
--- a/Source/platform/fonts/FontFallbackList.cpp
+++ b/Source/platform/fonts/FontFallbackList.cpp
@@ -34,6 +34,7 @@
#include "platform/fonts/FontDescription.h"
#include "platform/fonts/FontFamily.h"
#include "platform/fonts/SegmentedFontData.h"
+#include "wtf/unicode/CharacterNames.h"
namespace blink {
@@ -140,17 +141,17 @@ const SimpleFontData* FontFallbackList::determinePrimarySimpleFontData(const Fon
// All fonts are custom fonts and are loading. Return the first FontData.
fontData = fontDataAt(fontDescription, 0);
if (fontData)
- return fontData->fontDataForCharacter(' ');
+ return fontData->fontDataForCharacter(space);
SimpleFontData* lastResortFallback = FontCache::fontCache()->getLastResortFallbackFont(fontDescription).get();
ASSERT(lastResortFallback);
return lastResortFallback;
}
- if (fontData->isSegmented() && !toSegmentedFontData(fontData)->containsCharacter(' '))
+ if (fontData->isSegmented() && !toSegmentedFontData(fontData)->containsCharacter(space))
continue;
- const SimpleFontData* fontDataForSpace = fontData->fontDataForCharacter(' ');
+ const SimpleFontData* fontDataForSpace = fontData->fontDataForCharacter(space);
ASSERT(fontDataForSpace);
// When a custom font is loading, we should use the correct fallback font to layout the text.
« no previous file with comments | « Source/core/rendering/RenderText.cpp ('k') | Source/platform/fonts/GlyphPageTreeNode.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698