net/cert/cert_verify_proc_nss.cc - Issue 509273002: Detect SHA-1 when it appears in certificate chains

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/cert_verify_proc_nss.cc

Issue 509273002: Detect SHA-1 when it appears in certificate chains (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cert_status_extended

Patch Set: Correct Android comment Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/cert/cert_verify_proc_nss.cc

diff --git a/net/cert/cert_verify_proc_nss.cc b/net/cert/cert_verify_proc_nss.cc

index bd5232cf2821dc186e0672bd3351ae29a38490b9..1236f41dda43036f5a76343710f1cc8938bafaaa 100644

--- a/net/cert/cert_verify_proc_nss.cc

+++ b/net/cert/cert_verify_proc_nss.cc

@@ -203,6 +203,12 @@ void GetCertChainInfo(CERTCertList* cert_list,

case SEC_OID_PKCS1_MD4_WITH_RSA_ENCRYPTION:

verify_result->has_md4 = true;

break;

+ case SEC_OID_PKCS1_SHA1_WITH_RSA_ENCRYPTION:

+ case SEC_OID_ISO_SHA1_WITH_RSA_SIGNATURE:

+ case SEC_OID_ANSIX9_DSA_SIGNATURE_WITH_SHA1_DIGEST:

+ case SEC_OID_ANSIX962_ECDSA_SHA1_SIGNATURE:

+ verify_result->has_sha1 = true;

+ break;

default:

break;

}

« no previous file with comments | « net/cert/cert_verify_proc_mac.cc ('k') | net/cert/cert_verify_proc_openssl.cc » ('j') | no next file with comments »