net/cert/cert_verify_proc_mac.cc - Issue 509273002: Detect SHA-1 when it appears in certificate chains

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/cert_verify_proc_mac.cc

Issue 509273002: Detect SHA-1 when it appears in certificate chains (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cert_status_extended

Patch Set: Correct Android comment Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/cert/cert_verify_proc_mac.cc

diff --git a/net/cert/cert_verify_proc_mac.cc b/net/cert/cert_verify_proc_mac.cc

index 97c0bf13de63aa81d39a77790a233eb90426aa3c..709922598eaf20985dd67a50661dd9692ab33efc 100644

--- a/net/cert/cert_verify_proc_mac.cc

+++ b/net/cert/cert_verify_proc_mac.cc

@@ -227,6 +227,13 @@ void GetCertChainInfo(CFArrayRef cert_chain,

verify_result->has_md4 = true;

} else if (CSSMOIDEqual(alg_oid, &CSSMOID_MD5WithRSA)) {

verify_result->has_md5 = true;

+ } else if (CSSMOIDEqual(alg_oid, &CSSMOID_SHA1WithRSA) ||

+ CSSMOIDEqual(alg_oid, &CSSMOID_SHA1WithRSA_OIW) ||

+ CSSMOIDEqual(alg_oid, &CSSMOID_SHA1WithDSA) ||

+ CSSMOIDEqual(alg_oid, &CSSMOID_SHA1WithDSA_CMS) ||

+ CSSMOIDEqual(alg_oid, &CSSMOID_SHA1WithDSA_JDK) ||

+ CSSMOIDEqual(alg_oid, &CSSMOID_ECDSA_WithSHA1)) {

+ verify_result->has_sha1 = true;

}

if (!verified_cert)

« no previous file with comments | « net/cert/cert_verify_proc_android.cc ('k') | net/cert/cert_verify_proc_nss.cc » ('j') | no next file with comments »