Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(969)

Issue 509223002: High resolution timer fix reland (Closed)

Created:
6 years, 3 months ago by cpu_(ooo_6.6-7.5)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

High resolution timer fix reland On Windows the message pump code tried to manage the systemwide timer resolution to fire delayed tasks with better than 15ms resolution but it is buggy. This is https://codereview.chromium.org/395913006 please see that review for rationale. BUG=153139 TBR=jamesr,darin TEST=included, also see bug for manual verification. Committed: https://crrev.com/ee89079586f3a1ad727aad4c6aaf3100e220d6e4 Cr-Commit-Position: refs/heads/master@{#292493}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -101 lines) Patch
M base/message_loop/incoming_task_queue.h View 2 chunks +10 lines, -10 lines 0 comments Download
M base/message_loop/incoming_task_queue.cc View 4 chunks +25 lines, -52 lines 0 comments Download
M base/message_loop/message_loop.h View 3 chunks +9 lines, -5 lines 0 comments Download
M base/message_loop/message_loop.cc View 7 chunks +27 lines, -5 lines 0 comments Download
M base/message_loop/message_loop_unittest.cc View 1 chunk +7 lines, -17 lines 0 comments Download
M base/message_loop/message_pump.h View 1 chunk +2 lines, -1 line 0 comments Download
M base/pending_task.h View 2 chunks +3 lines, -3 lines 0 comments Download
M base/pending_task.cc View 2 chunks +4 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
cpu_(ooo_6.6-7.5)
cpu@chromium.org changed reviewers: + darin@chromium.org, jamesr@chromium.org
6 years, 3 months ago (2014-08-28 21:07:33 UTC) #1
cpu_(ooo_6.6-7.5)
relanding as new CL because the old CL is using svn as its root.
6 years, 3 months ago (2014-08-28 21:08:22 UTC) #2
jamesr
lgtm
6 years, 3 months ago (2014-08-28 21:15:16 UTC) #3
cpu_(ooo_6.6-7.5)
The CQ bit was checked by cpu@chromium.org
6 years, 3 months ago (2014-08-28 21:24:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cpu@chromium.org/509223002/1
6 years, 3 months ago (2014-08-28 21:26:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 2e032c3c2276678b3dcdfd5cec25e822cba80b87
6 years, 3 months ago (2014-08-28 23:25:51 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:03:21 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ee89079586f3a1ad727aad4c6aaf3100e220d6e4
Cr-Commit-Position: refs/heads/master@{#292493}

Powered by Google App Engine
This is Rietveld 408576698