Issue 5092007: Add registered shell extensions to enumerated module list on about:conflicts....

Issue 5092007: Add registered shell extensions to enumerated module list on about:conflicts.... (Closed)

Created:
10 years, 1 month ago by Finnur

Modified:
9 years, 6 months ago

Reviewers:
huanr

CC:
chromium-reviews, arv (Not doing code reviews), ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Add registered shell extensions to enumerated module list on about:conflicts. BUG=51105 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66756

Patch Set 2 : '' #

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+113 lines, -33 lines)			Patch
M	chrome/browser/enumerate_modules_model_win.h	View	1	2 chunks	+18 lines, -0 lines	0 comments	Download
M	chrome/browser/enumerate_modules_model_win.cc	View	1	6 chunks	+88 lines, -28 lines	0 comments	Download
M	chrome/browser/resources/about_conflicts.html	View	1	2 chunks	+7 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

huanr

http://codereview.chromium.org/5092007/diff/1/chrome/browser/enumerate_modules_model_win.cc File chrome/browser/enumerate_modules_model_win.cc (right): http://codereview.chromium.org/5092007/diff/1/chrome/browser/enumerate_modules_model_win.cc#newcode278 chrome/browser/enumerate_modules_model_win.cc:278: base::win::RegistryValueIterator registration(HKEY_LOCAL_MACHINE, kRegPath); Do you need to enumerate keys ...

10 years, 1 month ago (2010-11-18 22:01:13 UTC) #2

huanr

LGTM On 2010/11/18 22:01:13, huanr wrote: > http://codereview.chromium.org/5092007/diff/1/chrome/browser/enumerate_modules_model_win.cc > File chrome/browser/enumerate_modules_model_win.cc (right): > > http://codereview.chromium.org/5092007/diff/1/chrome/browser/enumerate_modules_model_win.cc#newcode278 ...

10 years, 1 month ago (2010-11-19 00:27:34 UTC) #3

Finnur

10 years, 1 month ago (2010-11-19 10:39:19 UTC) #4

No, you are right. I've added HKCU.

On 2010/11/19 00:27:34, huanr wrote:
> LGTM
> 
> On 2010/11/18 22:01:13, huanr wrote:
> >
>
http://codereview.chromium.org/5092007/diff/1/chrome/browser/enumerate_module...
> > File chrome/browser/enumerate_modules_model_win.cc (right):
> > 
> >
>
http://codereview.chromium.org/5092007/diff/1/chrome/browser/enumerate_module...
> > chrome/browser/enumerate_modules_model_win.cc:278:
> > base::win::RegistryValueIterator registration(HKEY_LOCAL_MACHINE, kRegPath);
> > Do you need to enumerate keys under HKCU?
> 
> Per conversation with Finnur, there is no entry under HKCU. A comment will be
> helpful.

Expand Messages | Collapse Messages