Chromium Code Reviews
Help | Chromium Project | Sign in
(552)

Issue 5092007: Add registered shell extensions to enumerated module list on about:conflicts.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 5 months ago by Finnur
Modified:
2 years, 10 months ago
Reviewers:
huanr
CC:
chromium-reviews_chromium.org, arv, ben+cc_chromium.org
Visibility:
Public.

Description

Add registered shell extensions to enumerated module list on about:conflicts.

BUG=51105
TEST=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66756

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -33 lines) Lint Patch
M chrome/browser/enumerate_modules_model_win.h View 1 2 chunks +18 lines, -0 lines 0 comments 0 errors Download
M chrome/browser/enumerate_modules_model_win.cc View 1 6 chunks +88 lines, -28 lines 0 comments 0 errors Download
M chrome/browser/resources/about_conflicts.html View 1 2 chunks +7 lines, -5 lines 0 comments 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 4
Finnur
3 years, 5 months ago #1
huanr
http://codereview.chromium.org/5092007/diff/1/chrome/browser/enumerate_modules_model_win.cc File chrome/browser/enumerate_modules_model_win.cc (right): http://codereview.chromium.org/5092007/diff/1/chrome/browser/enumerate_modules_model_win.cc#newcode278 chrome/browser/enumerate_modules_model_win.cc:278: base::win::RegistryValueIterator registration(HKEY_LOCAL_MACHINE, kRegPath); Do you need to enumerate keys ...
3 years, 5 months ago #2
huanr
LGTM On 2010/11/18 22:01:13, huanr wrote: > http://codereview.chromium.org/5092007/diff/1/chrome/browser/enumerate_modules_model_win.cc > File chrome/browser/enumerate_modules_model_win.cc (right): > > http://codereview.chromium.org/5092007/diff/1/chrome/browser/enumerate_modules_model_win.cc#newcode278 ...
3 years, 5 months ago #3
Finnur
3 years, 5 months ago #4
No, you are right. I've added HKCU.

On 2010/11/19 00:27:34, huanr wrote:
> LGTM
> 
> On 2010/11/18 22:01:13, huanr wrote:
> >
>
http://codereview.chromium.org/5092007/diff/1/chrome/browser/enumerate_module...
> > File chrome/browser/enumerate_modules_model_win.cc (right):
> > 
> >
>
http://codereview.chromium.org/5092007/diff/1/chrome/browser/enumerate_module...
> > chrome/browser/enumerate_modules_model_win.cc:278:
> > base::win::RegistryValueIterator registration(HKEY_LOCAL_MACHINE, kRegPath);
> > Do you need to enumerate keys under HKCU?
> 
> Per conversation with Finnur, there is no entry under HKCU. A comment will be
> helpful.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6