New bigint implementation in the vm.

runtime/vm/intermediate_language.cc

Index: runtime/vm/intermediate_language.cc
===================================================================
--- runtime/vm/intermediate_language.cc	(revision 39937)
+++ runtime/vm/intermediate_language.cc	(working copy)
@@ -4,7 +4,6 @@
 
 #include "vm/intermediate_language.h"
 
-#include "vm/bigint_operations.h"
 #include "vm/bit_vector.h"
 #include "vm/cpu.h"
 #include "vm/dart_entry.h"
@@ -382,10 +381,11 @@
 
 ConstantInstr::ConstantInstr(const Object& value) : value_(value) {
   // Check that the value is not an incorrect Integer representation.
-  ASSERT(!value.IsBigint() ||
-         !BigintOperations::FitsIntoSmi(Bigint::Cast(value)));
-  ASSERT(!value.IsBigint() ||
-         !BigintOperations::FitsIntoInt64(Bigint::Cast(value)));
+#if 0  // TODO(regis): Are these asserts correct? We need to be able to optimize
+       // bigint functions where small numbers are represented as bigint.
+  ASSERT(!value.IsBigint() || !Bigint::Cast(value).FitsIntoSmi());
+  ASSERT(!value.IsBigint() || !Bigint::Cast(value).FitsIntoInt64());

[srdjan, 2014/09/08 19:19:49]

We need these asserts in some form.

[regis, 2014/09/09 19:18:14]

I made the Bigint instances representing small numbers non-constant and
reinstated these asserts here.

+#endif
   ASSERT(!value.IsMint() || !Smi::IsValid(Mint::Cast(value).AsInt64Value()));
 }