New bigint implementation in the vm.

runtime/vm/intermediate_language.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/intermediate_language.h"
 
-#include "vm/bigint_operations.h"
 #include "vm/bit_vector.h"
 #include "vm/cpu.h"
 #include "vm/dart_entry.h"
 #include "vm/flow_graph_allocator.h"
 #include "vm/flow_graph_builder.h"
 #include "vm/flow_graph_compiler.h"
 #include "vm/flow_graph_optimizer.h"
 #include "vm/flow_graph_range_analysis.h"
 #include "vm/locations.h"
 #include "vm/method_recognizer.h"
@@ skipping 357 matching lines @@
 
 bool LoadIndexedInstr::AttributesEqual(Instruction* other) const {
   LoadIndexedInstr* other_load = other->AsLoadIndexed();
   ASSERT(other_load != NULL);
   return class_id() == other_load->class_id();
 }
 
 
 ConstantInstr::ConstantInstr(const Object& value) : value_(value) {
   // Check that the value is not an incorrect Integer representation.
-  ASSERT(!value.IsBigint() ||
-         !BigintOperations::FitsIntoSmi(Bigint::Cast(value)));
-  ASSERT(!value.IsBigint() ||
-         !BigintOperations::FitsIntoInt64(Bigint::Cast(value)));
+#if 0  // TODO(regis): Are these asserts correct? We need to be able to optimize
+       // bigint functions where small numbers are represented as bigint.
+  ASSERT(!value.IsBigint() || !Bigint::Cast(value).FitsIntoSmi());
+  ASSERT(!value.IsBigint() || !Bigint::Cast(value).FitsIntoInt64());

[srdjan, 2014/09/08 19:19:49]

We need these asserts in some form.

[regis, 2014/09/09 19:18:14]

I made the Bigint instances representing small numbers non-constant and
reinstated these asserts here.

+#endif
   ASSERT(!value.IsMint() || !Smi::IsValid(Mint::Cast(value).AsInt64Value()));
 }
 
 
 bool ConstantInstr::AttributesEqual(Instruction* other) const {
   ConstantInstr* other_constant = other->AsConstant();
   ASSERT(other_constant != NULL);
   return (value().raw() == other_constant->value().raw());
 }
 
@@ skipping 2696 matching lines @@
     case Token::kTRUNCDIV: return 0;
     case Token::kMOD: return 1;
     default: UNIMPLEMENTED(); return -1;
   }
 }
 
 
 #undef __
 
 }  // namespace dart