Initial change to create GeometryProcessor

include/gpu/GrEffectStage.h

Index: include/gpu/GrEffectStage.h
diff --git a/include/gpu/GrEffectStage.h b/include/gpu/GrEffectStage.h
index 65c7bebdc7056f7da58960ea61e489fd5c2cd73d..33b53773a8ec3f8a0730a67de9ada01112f83932 100644
--- a/include/gpu/GrEffectStage.h
+++ b/include/gpu/GrEffectStage.h
@@ -18,8 +18,10 @@
 
 #include "SkShader.h"
 
-class GrEffectStage {
+class GrEffectStage : public SkRefCnt {
 public:
+    SK_DECLARE_INST_COUNT(GrEffectStage);
+
     explicit GrEffectStage(const GrEffect* effect, int attrIndex0 = -1, int attrIndex1 = -1)
     : fEffect(SkRef(effect)) {
         fCoordChangeMatrixSet = false;
@@ -27,7 +29,7 @@ public:
         fVertexAttribIndices[1] = attrIndex1;
     }
 

[robertphillips, 2014/08/29 15:04:53]

We don't usually add the explicit empty INHERITED() calls.

[joshua.litt, 2014/09/02 16:06:21]

Well, if I don't do this then I get a warning on mac:

[13:40:23.791929] ../../include/gpu/GrEffectStage.h: In copy constructor
‘GrEffectStage::GrEffectStage(const GrEffectStage&)’:
[13:40:23.791974] ../../include/gpu/GrEffectStage.h:32: warning: base class
‘class SkRefCnt’ should be explicitly initialized in the copy constructor

-    GrEffectStage(const GrEffectStage& other) {
+    GrEffectStage(const GrEffectStage& other) : INHERITED() {

[bsalomon, 2014/08/29 15:07:25]

We don't require explicit calls of default cons for members or base classes.

[joshua.litt, 2014/09/02 16:06:21]

see above

         *this = other;
     }
 
@@ -141,6 +143,8 @@ private:
     SkMatrix                            fCoordChangeMatrix;
     SkAutoTUnref<const GrEffect>        fEffect;
     int                                 fVertexAttribIndices[2];
+
+    typedef SkRefCnt INHERITED;
 };
 
 #endif