Initial change to create GeometryProcessor

include/gpu/GrEffectStage.h

 
 /*
  * Copyright 2010 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 
 
 #ifndef GrEffectStage_DEFINED
 #define GrEffectStage_DEFINED
 
 #include "GrBackendEffectFactory.h"
 #include "GrEffect.h"
 #include "SkMatrix.h"
 #include "GrTypes.h"
 
 #include "SkShader.h"
 
-class GrEffectStage {
+class GrEffectStage : public SkRefCnt {
 public:
+    SK_DECLARE_INST_COUNT(GrEffectStage);
+
     explicit GrEffectStage(const GrEffect* effect, int attrIndex0 = -1, int attrIndex1 = -1)
     : fEffect(SkRef(effect)) {
         fCoordChangeMatrixSet = false;
         fVertexAttribIndices[0] = attrIndex0;
         fVertexAttribIndices[1] = attrIndex1;
     }
 

[robertphillips, 2014/08/29 15:04:53]

We don't usually add the explicit empty INHERITED() calls.

[joshua.litt, 2014/09/02 16:06:21]

Well, if I don't do this then I get a warning on mac:

[13:40:23.791929] ../../include/gpu/GrEffectStage.h: In copy constructor
‘GrEffectStage::GrEffectStage(const GrEffectStage&)’:
[13:40:23.791974] ../../include/gpu/GrEffectStage.h:32: warning: base class
‘class SkRefCnt’ should be explicitly initialized in the copy constructor

-    GrEffectStage(const GrEffectStage& other) {
+    GrEffectStage(const GrEffectStage& other) : INHERITED() {

[bsalomon, 2014/08/29 15:07:25]

We don't require explicit calls of default cons for members or base classes.

[joshua.litt, 2014/09/02 16:06:21]

see above

         *this = other;
     }
 
     GrEffectStage& operator= (const GrEffectStage& other) {
         fCoordChangeMatrixSet = other.fCoordChangeMatrixSet;
         if (other.fCoordChangeMatrixSet) {
             fCoordChangeMatrix = other.fCoordChangeMatrix;
         }
         fEffect.reset(SkRef(other.fEffect.get()));
         memcpy(fVertexAttribIndices, other.fVertexAttribIndices, sizeof(fVertexAttribIndices));
@@ skipping 93 matching lines @@
     const GrEffect* getEffect() const { return fEffect.get(); }
 
     const int* getVertexAttribIndices() const { return fVertexAttribIndices; }
     int getVertexAttribIndexCount() const { return fEffect->numVertexAttribs(); }
 
 private:
     bool                                fCoordChangeMatrixSet;
     SkMatrix                            fCoordChangeMatrix;
     SkAutoTUnref<const GrEffect>        fEffect;
     int                                 fVertexAttribIndices[2];
+
+    typedef SkRefCnt INHERITED;
 };
 
 #endif