Issue 509143002: Make gn deps for extensions API registration consistent with gyp dependencies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 509143002: Make gn deps for extensions API registration consistent with gyp dependencies. (Closed)

Created:
6 years, 3 months ago by Yoyo Zhou

Modified:
6 years, 3 months ago

Reviewers:
scottmg

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src@master

Project:
chromium

Visibility:
Public.

Make gn deps for extensions API registration consistent with gyp dependencies. BUG=405226 Committed: https://crrev.com/14cc3e825bd5a7c451d45f21e5642dd0aa43bcbf Cr-Commit-Position: refs/heads/master@{#292230}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -4 lines)			Patch
	M	chrome/common/extensions/api/BUILD.gn	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	extensions/common/api/BUILD.gn	View		1 chunk	+7 lines, -4 lines	0 comments	Download

Total messages: 7 (0 generated)

Yoyo Zhou

yoz@chromium.org changed reviewers: + scottmg@chromium.org

6 years, 3 months ago (2014-08-27 20:03:59 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/509143002/1

6 years, 3 months ago (2014-08-27 20:35:27 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as 4958ec4c2107385428efce1e12d81abf2a8025da

6 years, 3 months ago (2014-08-27 21:33:08 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 02:54:17 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/14cc3e825bd5a7c451d45f21e5642dd0aa43bcbf
Cr-Commit-Position: refs/heads/master@{#292230}