extensions/common/api/BUILD.gn - Issue 509143002: Make gn deps for extensions API registration consistent with gyp dependencies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/api/BUILD.gn

Issue 509143002: Make gn deps for extensions API registration consistent with gyp dependencies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/common/api/BUILD.gn

diff --git a/extensions/common/api/BUILD.gn b/extensions/common/api/BUILD.gn

index 10a69fa80f8f71c480efe914222796de9c3bd41a..8d2e3cf1fc361423b1595e7c512932710b858508 100644

--- a/extensions/common/api/BUILD.gn

+++ b/extensions/common/api/BUILD.gn

@@ -16,8 +16,11 @@ generated_extensions_api("api_registration") {

impl_dir = "//extensions/browser/api"

bundle_registration = true

- deps = [

- "//device/serial",

- "//skia",

- ]

+ deps = [ ":api" ]

+ if (!is_android) {

+ deps += [

+ "//device/serial",

+ "//skia",

+ ]

+ }

}

« no previous file with comments | « chrome/common/extensions/api/BUILD.gn ('k') | no next file » | no next file with comments »