Raw SocketDescriptor variant of UnixDomainServerSocket::Accept

net/socket/unix_domain_client_socket_posix_unittest.cc

Index: net/socket/unix_domain_client_socket_posix_unittest.cc
diff --git a/net/socket/unix_domain_client_socket_posix_unittest.cc b/net/socket/unix_domain_client_socket_posix_unittest.cc
index ff15246d8e13f604197dbce5eda2b6be5303c5da..20daf3617f710e16b42508db5a8fd3731f41d167 100644
--- a/net/socket/unix_domain_client_socket_posix_unittest.cc
+++ b/net/socket/unix_domain_client_socket_posix_unittest.cc
@@ -148,6 +148,32 @@ TEST_F(UnixDomainClientSocketTest, Connect) {
   EXPECT_TRUE(accepted_socket->IsConnected());
 }
 
+TEST_F(UnixDomainClientSocketTest, ConnectWithSocketDescriptor) {
+  const bool kUseAbstractNamespace = false;
+
+  UnixDomainServerSocket server_socket(CreateAuthCallback(true),
+                                       kUseAbstractNamespace);
+  EXPECT_EQ(OK, server_socket.ListenWithAddressAndPort(socket_path_, 0, 1));
+
+  SocketDescriptor accepted_socket = kInvalidSocket;
+  TestCompletionCallback accept_callback;
+  EXPECT_EQ(ERR_IO_PENDING,
+            server_socket.AcceptSocketDescriptor(&accepted_socket,
+                                                 accept_callback.callback()));
+  EXPECT_EQ(accepted_socket, kInvalidSocket);

[byungchul, 2014/08/27 23:35:51]

expected value should go first.

[Chris Masone, 2014/08/28 17:53:16]

Done.

+
+  UnixDomainClientSocket client_socket(socket_path_, kUseAbstractNamespace);
+  EXPECT_FALSE(client_socket.IsConnected());
+
+  EXPECT_EQ(OK, ConnectSynchronously(&client_socket));
+  EXPECT_TRUE(client_socket.IsConnected());
+  // Server has not yet been notified of the connection.
+  EXPECT_EQ(accepted_socket, kInvalidSocket);

[byungchul, 2014/08/27 23:35:51]

ditto

[Chris Masone, 2014/08/28 17:53:16]

Done.

+
+  EXPECT_EQ(OK, accept_callback.WaitForResult());
+  EXPECT_GT(accepted_socket, 0);

[byungchul, 2014/08/27 23:35:51]

EXPECT_NE(kInvalidSocket, accepted_socket) because we have no assumption on
socket fd except kInvalidSocket.

[Chris Masone, 2014/08/28 17:53:16]

Done.

+}
+
 TEST_F(UnixDomainClientSocketTest, ConnectWithAbstractNamespace) {
   const bool kUseAbstractNamespace = true;