Raw SocketDescriptor variant of UnixDomainServerSocket::Accept

net/socket/unix_domain_client_socket_posix_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/socket/unix_domain_client_socket_posix.h"
 
 #include <unistd.h>
 
 #include "base/bind.h"
 #include "base/files/file_path.h"
@@ skipping 130 matching lines @@
   EXPECT_EQ(OK, ConnectSynchronously(&client_socket));
   EXPECT_TRUE(client_socket.IsConnected());
   // Server has not yet been notified of the connection.
   EXPECT_FALSE(accepted_socket);
 
   EXPECT_EQ(OK, accept_callback.WaitForResult());
   EXPECT_TRUE(accepted_socket);
   EXPECT_TRUE(accepted_socket->IsConnected());
 }
 
+TEST_F(UnixDomainClientSocketTest, ConnectWithSocketDescriptor) {
+  const bool kUseAbstractNamespace = false;
+
+  UnixDomainServerSocket server_socket(CreateAuthCallback(true),
+                                       kUseAbstractNamespace);
+  EXPECT_EQ(OK, server_socket.ListenWithAddressAndPort(socket_path_, 0, 1));
+
+  SocketDescriptor accepted_socket = kInvalidSocket;
+  TestCompletionCallback accept_callback;
+  EXPECT_EQ(ERR_IO_PENDING,
+            server_socket.AcceptSocketDescriptor(&accepted_socket,
+                                                 accept_callback.callback()));
+  EXPECT_EQ(accepted_socket, kInvalidSocket);

[byungchul, 2014/08/27 23:35:51]

expected value should go first.

[Chris Masone, 2014/08/28 17:53:16]

Done.

+
+  UnixDomainClientSocket client_socket(socket_path_, kUseAbstractNamespace);
+  EXPECT_FALSE(client_socket.IsConnected());
+
+  EXPECT_EQ(OK, ConnectSynchronously(&client_socket));
+  EXPECT_TRUE(client_socket.IsConnected());
+  // Server has not yet been notified of the connection.
+  EXPECT_EQ(accepted_socket, kInvalidSocket);

[byungchul, 2014/08/27 23:35:51]

ditto

[Chris Masone, 2014/08/28 17:53:16]

Done.

+
+  EXPECT_EQ(OK, accept_callback.WaitForResult());
+  EXPECT_GT(accepted_socket, 0);

[byungchul, 2014/08/27 23:35:51]

EXPECT_NE(kInvalidSocket, accepted_socket) because we have no assumption on
socket fd except kInvalidSocket.

[Chris Masone, 2014/08/28 17:53:16]

Done.

+}
+
 TEST_F(UnixDomainClientSocketTest, ConnectWithAbstractNamespace) {
   const bool kUseAbstractNamespace = true;
 
   UnixDomainClientSocket client_socket(socket_path_, kUseAbstractNamespace);
   EXPECT_FALSE(client_socket.IsConnected());
 
 #if defined(OS_ANDROID) || defined(OS_LINUX)
   UnixDomainServerSocket server_socket(CreateAuthCallback(true),
                                        kUseAbstractNamespace);
   EXPECT_EQ(OK, server_socket.ListenWithAddressAndPort(socket_path_, 0, 1));
@@ skipping 226 matching lines @@
                 accepted_socket.get(), read_buffer.get(), kReadBufferSize, 0));
 
   // Disconnect from server side after read-write.
   accepted_socket->Disconnect();
   EXPECT_FALSE(accepted_socket->IsConnected());
   EXPECT_FALSE(client_socket.IsConnected());
 }
 
 }  // namespace
 }  // namespace net