Issue 509073004: Change TransmissionInfo's all_transmissions SequenceNumberSet* to

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 509073004: Change TransmissionInfo's all_transmissions SequenceNumberSet* to (Closed)

Created:
6 years, 3 months ago by ramant (doing other things)

Modified:
6 years, 3 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@log_quic_version_74069715

Project:
chromium

Visibility:
Public.

More Reviews

Description

Change TransmissionInfo's all_transmissions SequenceNumberSet* to default to NULL, and only be present if there are multiple transmissions. Estimated to save ~2% of CPU. Merge internal change: 74076012 R=rch@chromium.org

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+48 lines, -59 lines)			Patch
M	net/quic/quic_protocol.h	View	3 chunks	+3 lines, -4 lines	0 comments	Download
M	net/quic/quic_protocol.cc	View	3 chunks	+4 lines, -10 lines	0 comments	Download
M	net/quic/quic_sent_packet_manager.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/quic_sent_packet_manager.cc	View	4 chunks	+23 lines, -29 lines	0 comments	Download
M	net/quic/quic_unacked_packet_map.cc	View	7 chunks	+16 lines, -14 lines	0 comments	Download
M	net/quic/test_tools/quic_sent_packet_manager_peer.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages