Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1409)

Unified Diff: net/quic/quic_protocol.h

Issue 509073004: Change TransmissionInfo's all_transmissions SequenceNumberSet* to (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@log_quic_version_74069715
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/quic_protocol.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_protocol.h
diff --git a/net/quic/quic_protocol.h b/net/quic/quic_protocol.h
index 0d9fb84ba6f3dd69ccdba86e0008dd7981e4b460..a15c91289e84261f4ff7fa6f40b8250784e58259 100644
--- a/net/quic/quic_protocol.h
+++ b/net/quic/quic_protocol.h
@@ -647,6 +647,7 @@ struct NET_EXPORT_PRIVATE QuicStreamFrame {
// TODO(ianswett): Re-evaluate the trade-offs of hash_set vs set when framing
// is finalized.
typedef std::set<QuicPacketSequenceNumber> SequenceNumberSet;
+typedef std::list<QuicPacketSequenceNumber> SequenceNumberList;
typedef std::list<std::pair<QuicPacketSequenceNumber, QuicTime>> PacketTimeList;
@@ -1053,16 +1054,14 @@ struct NET_EXPORT_PRIVATE TransmissionInfo {
// Constructs a Transmission with a new all_tranmissions set
// containing |sequence_number|.
TransmissionInfo(RetransmittableFrames* retransmittable_frames,
- QuicPacketSequenceNumber sequence_number,
QuicSequenceNumberLength sequence_number_length);
// Constructs a Transmission with the specified |all_tranmissions| set
// and inserts |sequence_number| into it.
TransmissionInfo(RetransmittableFrames* retransmittable_frames,
- QuicPacketSequenceNumber sequence_number,
QuicSequenceNumberLength sequence_number_length,
TransmissionType transmission_type,
- SequenceNumberSet* all_transmissions);
+ SequenceNumberList* all_transmissions);
RetransmittableFrames* retransmittable_frames;
QuicSequenceNumberLength sequence_number_length;
@@ -1075,7 +1074,7 @@ struct NET_EXPORT_PRIVATE TransmissionInfo {
TransmissionType transmission_type;
// Stores the sequence numbers of all transmissions of this packet.
// Can never be null.
- SequenceNumberSet* all_transmissions;
+ SequenceNumberList* all_transmissions;
// In flight packets have not been abandoned or lost.
bool in_flight;
};
« no previous file with comments | « no previous file | net/quic/quic_protocol.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698