Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 509063004: Move ViewMsg_Stop from RenderViewHost to RenderFrameHost. (Closed)

Created:
6 years, 3 months ago by nasko
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, site-isolation-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Committed: https://crrev.com/85f602228092a51eefddcf9016299faa7219f8c0 Cr-Commit-Position: refs/heads/master@{#292486}

Patch Set 1 : Equivalent to original CL (https://codereview.chromium.org/479403004/) #

Patch Set 2 : Revert the enabling of the test. #

Patch Set 3 : Rebase on ToT. #

Patch Set 4 : Another rebase to fix patch failure. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -62 lines) Patch
M chrome/browser/ui/cocoa/applescript/tab_applescript.mm View 1 chunk +1 line, -9 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 2 3 2 chunks +5 lines, -1 line 0 comments Download
M content/browser/frame_host/render_frame_host_manager.cc View 1 2 3 2 chunks +5 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/web_contents/web_contents_impl_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/common/frame_messages.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M content/common/view_messages.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/browser/render_widget_host.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 2 2 chunks +1 line, -3 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 3 8 chunks +16 lines, -12 lines 0 comments Download
M content/renderer/render_frame_proxy.cc View 1 2 1 chunk +4 lines, -10 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 2 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
nasko
nasko@chromium.org changed reviewers: + creis@chromium.org
6 years, 3 months ago (2014-08-28 17:38:24 UTC) #1
nasko
Hey Charlie, Can you review this CL? It is equivalent to the previous one where ...
6 years, 3 months ago (2014-08-28 17:38:25 UTC) #2
nasko
nasko@chromium.org changed reviewers: + avi@chromium.org
6 years, 3 months ago (2014-08-28 17:39:23 UTC) #3
nasko
Adding avi@ for the Mac change, which is identical to the previous CL.
6 years, 3 months ago (2014-08-28 17:39:23 UTC) #4
Avi (use Gerrit)
Mac stuff slgtm.
6 years, 3 months ago (2014-08-28 18:04:20 UTC) #5
Avi (use Gerrit)
On 2014/08/28 18:04:20, Avi wrote: > Mac stuff slgtm. still lgtm
6 years, 3 months ago (2014-08-28 18:04:28 UTC) #6
Charlie Reis
LGTM
6 years, 3 months ago (2014-08-28 18:24:05 UTC) #7
nasko
The CQ bit was checked by nasko@chromium.org
6 years, 3 months ago (2014-08-28 18:43:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nasko@chromium.org/509063004/60001
6 years, 3 months ago (2014-08-28 18:43:52 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-28 19:57:25 UTC) #10
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-08-28 19:57:26 UTC) #11
nasko
The CQ bit was checked by nasko@chromium.org
6 years, 3 months ago (2014-08-28 19:58:07 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nasko@chromium.org/509063004/60001
6 years, 3 months ago (2014-08-28 20:00:21 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-28 20:02:50 UTC) #14
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-08-28 20:02:51 UTC) #15
nasko
The CQ bit was checked by nasko@chromium.org
6 years, 3 months ago (2014-08-28 20:18:26 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nasko@chromium.org/509063004/60001
6 years, 3 months ago (2014-08-28 20:18:51 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-28 20:20:43 UTC) #18
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-08-28 20:20:44 UTC) #19
nasko
Committed patchset #4 (id:60001) to pending queue manually as 8285933 (presubmit successful).
6 years, 3 months ago (2014-08-28 22:54:01 UTC) #20
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:03:07 UTC) #21
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/85f602228092a51eefddcf9016299faa7219f8c0
Cr-Commit-Position: refs/heads/master@{#292486}

Powered by Google App Engine
This is Rietveld 408576698