Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Side by Side Diff: content/renderer/render_frame_proxy.cc

Issue 509063004: Move ViewMsg_Stop from RenderViewHost to RenderFrameHost. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Another rebase to fix patch failure. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | content/renderer/render_view_impl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/render_frame_proxy.h" 5 #include "content/renderer/render_frame_proxy.h"
6 6
7 #include <map> 7 #include <map>
8 8
9 #include "base/lazy_instance.h" 9 #include "base/lazy_instance.h"
10 #include "content/common/frame_messages.h" 10 #include "content/common/frame_messages.h"
(...skipping 21 matching lines...) Expand all
32 32
33 // static 33 // static
34 RenderFrameProxy* RenderFrameProxy::CreateProxyToReplaceFrame( 34 RenderFrameProxy* RenderFrameProxy::CreateProxyToReplaceFrame(
35 RenderFrameImpl* frame_to_replace, 35 RenderFrameImpl* frame_to_replace,
36 int routing_id) { 36 int routing_id) {
37 CHECK_NE(routing_id, MSG_ROUTING_NONE); 37 CHECK_NE(routing_id, MSG_ROUTING_NONE);
38 38
39 scoped_ptr<RenderFrameProxy> proxy( 39 scoped_ptr<RenderFrameProxy> proxy(
40 new RenderFrameProxy(routing_id, frame_to_replace->GetRoutingID())); 40 new RenderFrameProxy(routing_id, frame_to_replace->GetRoutingID()));
41 41
42 blink::WebRemoteFrame* web_frame = NULL; 42 // When a RenderFrame is replaced by a RenderProxy, the WebRemoteFrame should
43 if (frame_to_replace->GetWebFrame()->parent() && 43 // always come from WebRemoteFrame::create and a call to WebFrame::swap must
44 frame_to_replace->GetWebFrame()->parent()->isWebRemoteFrame()) { 44 // follow later.
45 blink::WebRemoteFrame* parent_web_frame = 45 blink::WebRemoteFrame* web_frame = blink::WebRemoteFrame::create(proxy.get());
46 frame_to_replace->GetWebFrame()->parent()->toWebRemoteFrame();
47 web_frame = parent_web_frame->createRemoteChild("", proxy.get());
48 } else {
49 web_frame = blink::WebRemoteFrame::create(proxy.get());
50 }
51
52 proxy->Init(web_frame, frame_to_replace->render_view()); 46 proxy->Init(web_frame, frame_to_replace->render_view());
53 return proxy.release(); 47 return proxy.release();
54 } 48 }
55 49
56 RenderFrameProxy* RenderFrameProxy::CreateFrameProxy( 50 RenderFrameProxy* RenderFrameProxy::CreateFrameProxy(
57 int routing_id, 51 int routing_id,
58 int parent_routing_id, 52 int parent_routing_id,
59 int render_view_routing_id) { 53 int render_view_routing_id) {
60 scoped_ptr<RenderFrameProxy> proxy( 54 scoped_ptr<RenderFrameProxy> proxy(
61 new RenderFrameProxy(routing_id, MSG_ROUTING_NONE)); 55 new RenderFrameProxy(routing_id, MSG_ROUTING_NONE));
(...skipping 180 matching lines...) Expand 10 before | Expand all | Expand 10 after
242 if (render_frame->GetWebFrame()->opener()) 236 if (render_frame->GetWebFrame()->opener())
243 render_frame->GetWebFrame()->setOpener(NULL); 237 render_frame->GetWebFrame()->setOpener(NULL);
244 return; 238 return;
245 } 239 }
246 240
247 if (web_frame_->opener()) 241 if (web_frame_->opener())
248 web_frame_->setOpener(NULL); 242 web_frame_->setOpener(NULL);
249 } 243 }
250 244
251 } // namespace 245 } // namespace
OLDNEW
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | content/renderer/render_view_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698