tools/telemetry/telemetry/core/platform/mac_platform_backend.py - Issue 509043002: [Telemetry] Combine SysfsPlatformBackend into LinuxBasedPlatformBackend.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/platform/mac_platform_backend.py

Issue 509043002: [Telemetry] Combine SysfsPlatformBackend into LinuxBasedPlatformBackend. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/platform/linux_platform_backend_unittest.py ('k') | tools/telemetry/telemetry/core/platform/posix_platform_backend.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/platform/mac_platform_backend.py

diff --git a/tools/telemetry/telemetry/core/platform/mac_platform_backend.py b/tools/telemetry/telemetry/core/platform/mac_platform_backend.py

index 1823483406064106f1870b2d00b8f1fdb1339b7d..657ba6863717be4e1b9987c3f23a9dcf6b9cdd75 100644

--- a/tools/telemetry/telemetry/core/platform/mac_platform_backend.py

+++ b/tools/telemetry/telemetry/core/platform/mac_platform_backend.py

@@ -100,7 +100,7 @@ class MacPlatformBackend(posix_platform_backend.PosixPlatformBackend):

return {'TotalTime': time.time()}

def GetSystemCommitCharge(self):

- vm_stat = self._RunCommand(['vm_stat'])

+ vm_stat = self.RunCommand(['vm_stat'])

for stat in vm_stat.splitlines():

key, value = stat.split(':')

if key == 'Pages active':

@@ -110,14 +110,14 @@ class MacPlatformBackend(posix_platform_backend.PosixPlatformBackend):

@decorators.Cache

def GetSystemTotalPhysicalMemory(self):

- return int(self._RunCommand(['sysctl', '-n', 'hw.memsize']))

+ return int(self.RunCommand(['sysctl', '-n', 'hw.memsize']))

def PurgeUnpinnedMemory(self):

# TODO(pliard): Implement this.

pass

def GetMemoryStats(self, pid):

- rss_vsz = self._GetPsOutput(['rss', 'vsz'], pid)

+ rss_vsz = self.GetPsOutput(['rss', 'vsz'], pid)

if rss_vsz:

rss, vsz = rss_vsz[0].split()

return {'VM': 1024 * int(vsz),