Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 508893002: Disabled PasswordGenerationInteractiveTest.* as they are flaky. (Closed)

Created:
6 years, 3 months ago by benwells
Modified:
6 years, 3 months ago
Reviewers:
Garrett Casto
CC:
chromium-reviews, gcasto+watchlist_chromium.org, mkwst+watchlist_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Disabled PasswordGenerationInteractiveTest.* as they are flaky. TBR=gcasto NOTRY=true BUG=407998 Committed: https://crrev.com/58618fabb76b73270f8301cfc4f4dd671f59c91f Cr-Commit-Position: refs/heads/master@{#292115}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M chrome/browser/password_manager/password_generation_interactive_uitest.cc View 1 chunk +10 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
benwells
benwells@chromium.org changed reviewers: + gcasto@chromium.org
6 years, 3 months ago (2014-08-27 07:15:51 UTC) #1
benwells
6 years, 3 months ago (2014-08-27 07:16:02 UTC) #2
benwells
btw, feel free to reorganize your macros. Might make more sense to wrap the test ...
6 years, 3 months ago (2014-08-27 07:17:18 UTC) #3
benwells
The CQ bit was checked by benwells@chromium.org
6 years, 3 months ago (2014-08-27 07:17:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/508893002/1
6 years, 3 months ago (2014-08-27 07:18:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (1) as de0ce9c5114366899de82e1cbb57ebbba34c8235
6 years, 3 months ago (2014-08-27 07:19:01 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:50:22 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/58618fabb76b73270f8301cfc4f4dd671f59c91f
Cr-Commit-Position: refs/heads/master@{#292115}

Powered by Google App Engine
This is Rietveld 408576698