Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1608)

Unified Diff: chrome/browser/password_manager/password_generation_interactive_uitest.cc

Issue 508893002: Disabled PasswordGenerationInteractiveTest.* as they are flaky. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/password_manager/password_generation_interactive_uitest.cc
diff --git a/chrome/browser/password_manager/password_generation_interactive_uitest.cc b/chrome/browser/password_manager/password_generation_interactive_uitest.cc
index 183b5f9b4bacf9d0320a16219552bb280a249d69..686d1ad40c2e06df861586b591f5f225bd9822d6 100644
--- a/chrome/browser/password_manager/password_generation_interactive_uitest.cc
+++ b/chrome/browser/password_manager/password_generation_interactive_uitest.cc
@@ -136,14 +136,19 @@ class PasswordGenerationInteractiveTest : public InProcessBrowserTest {
#if defined(USE_AURA)
// Enabled on these platforms.
-#define MAYBE_PopupShownAndPasswordSelected PopupShownAndPasswordSelected
-#define MAYBE_PopupShownAndDismissed PopupShownAndDismissed
-#define MAYBE_PopupShownAndDismissedByScrolling PopupShownAndDismissedByScrolling
+// Disabled due to flakiness, see http://crbug.com/407998
+#define MAYBE_PopupShownAndPasswordSelected \
+ DISABLED_PopupShownAndPasswordSelected
+#define MAYBE_PopupShownAndDismissed DISABLED_PopupShownAndDismissed
+#define MAYBE_PopupShownAndDismissedByScrolling \
+ DISABLED_PopupShownAndDismissedByScrolling
#else
// Popup not enabled for these platforms yet.
-#define MAYBE_PopupShownAndPasswordSelected DISABLED_PopupShownAndPasswordSelected
+#define MAYBE_PopupShownAndPasswordSelected \
+ DISABLED_PopupShownAndPasswordSelected
#define MAYBE_PopupShownAndDismissed DISABLED_PopupShownAndDismissed
-#define MAYBE_PopupShownAndDismissedByScrolling DISABLED_PopupShownAndDismissedByScrolling
+#define MAYBE_PopupShownAndDismissedByScrolling \
+ DISABLED_PopupShownAndDismissedByScrolling
#endif
IN_PROC_BROWSER_TEST_F(PasswordGenerationInteractiveTest,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698