Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1640)

Unified Diff: net/url_request/url_request_http_job.cc

Issue 508823009: Mark SHA-1 as deprecated (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cert_verify_result_sha1
Patch Set: Moar work Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/cert/cert_status_flags_list.h ('K') | « net/spdy/spdy_session.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_http_job.cc
diff --git a/net/url_request/url_request_http_job.cc b/net/url_request/url_request_http_job.cc
index 3c777a3b9a7371aa2bbcdf713237aa281678ea07..63190f5c1492b3a5c78c583d6c52497a1f9e216b 100644
--- a/net/url_request/url_request_http_job.cc
+++ b/net/url_request/url_request_http_job.cc
@@ -744,7 +744,8 @@ void URLRequestHttpJob::ProcessStrictTransportSecurityHeader() {
// Only accept HSTS headers on HTTPS connections that have no
// certificate errors.
- if (!ssl_info.is_valid() || IsCertStatusError(ssl_info.cert_status) ||
+ if (!ssl_info.is_valid() || (IsCertStatusError(ssl_info.cert_status) &&
+ !IsCertStatusMinorError(ssl_info.cert_status)) ||
!security_state)
return;
@@ -767,7 +768,8 @@ void URLRequestHttpJob::ProcessPublicKeyPinsHeader() {
// Only accept HPKP headers on HTTPS connections that have no
// certificate errors.
- if (!ssl_info.is_valid() || IsCertStatusError(ssl_info.cert_status) ||
+ if (!ssl_info.is_valid() || (IsCertStatusError(ssl_info.cert_status) &&
+ !IsCertStatusMinorError(ssl_info.cert_status)) ||
!security_state)
return;
« net/cert/cert_status_flags_list.h ('K') | « net/spdy/spdy_session.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698