net/cert/cert_status_flags_list.h - Issue 508823009: Mark SHA-1 as deprecated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/cert_status_flags_list.h

Issue 508823009: Mark SHA-1 as deprecated (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cert_verify_result_sha1

Patch Set: Moar work Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/cert/cert_status_flags_list.h

diff --git a/net/cert/cert_status_flags_list.h b/net/cert/cert_status_flags_list.h

index 516631387d2db9968560c54d2aae155aaa39bc43..b2bcd319576294f45d9d161d461c5d9cf613c8b2 100644

--- a/net/cert/cert_status_flags_list.h

+++ b/net/cert/cert_status_flags_list.h

@@ -24,6 +24,9 @@ CERT_STATUS_FLAG(WEAK_KEY, 1 << 11)

// 1 << 12 was used for CERT_STATUS_WEAK_DH_KEY

CERT_STATUS_FLAG(PINNED_KEY_MISSING, 1 << 13)

CERT_STATUS_FLAG(NAME_CONSTRAINT_VIOLATION, 1 << 14)

+// Deprecated means "Valid beyond the deprecation period" (e.g. SHA-1 in 2017)

davidben 2014/09/26 20:09:24 This comment is off. The flag is actually set for

+// If used after the deprecation period, it becomes WEAK_SIGNATURE_ALGORITHM

+CERT_STATUS_FLAG(DEPRECATED_SIGNATURE_ALGORITHM, 1 << 15)

// Bits 16 to 31 are for non-error statuses.

CERT_STATUS_FLAG(IS_EV, 1 << 16)