net/http/http_cache_transaction.cc - Issue 508823009: Mark SHA-1 as deprecated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_cache_transaction.cc

Issue 508823009: Mark SHA-1 as deprecated (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cert_verify_result_sha1

Patch Set: Moar work Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_cache_transaction.cc

diff --git a/net/http/http_cache_transaction.cc b/net/http/http_cache_transaction.cc

index b06e8f3a272b4df533756a423f5a5fc0b321b532..f8aeb786e2882bd9b9fd82e89a19b3678fdf492c 100644

--- a/net/http/http_cache_transaction.cc

+++ b/net/http/http_cache_transaction.cc

@@ -2636,7 +2636,8 @@ int HttpCache::Transaction::WriteResponseInfoToEntry(bool truncated) {

// reverse-map the cert status to a net error and replay the net error.

if ((cache_->mode() != RECORD &&

response_.headers->HasHeaderValue("cache-control", "no-store")) ||

- net::IsCertStatusError(response_.ssl_info.cert_status)) {

+ (net::IsCertStatusError(response_.ssl_info.cert_status) &&

+ !net::IsCertStatusMinorError(response_.ssl_info.cert_status))) {

DoneWritingToEntry(false);

if (net_log_.IsLogging())

net_log_.EndEvent(NetLog::TYPE_HTTP_CACHE_WRITE_INFO);