Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/browser/download/download_resource_handler.cc

Issue 508823009: Mark SHA-1 as deprecated (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cert_verify_result_sha1
Patch Set: Moar work Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/ui/toolbar/toolbar_model_impl.cc ('K') | « components/password_manager/content/browser/content_password_manager_driver.cc ('k') | content/browser/ssl/ssl_policy.cc » ('j') | content/browser/ssl/ssl_policy.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/download/download_resource_handler.cc
diff --git a/content/browser/download/download_resource_handler.cc b/content/browser/download/download_resource_handler.cc
index f2fb2a5b267f68158625704cbb4a9f09ee9952d4..7516761bd62dd25e0cf751c79d1baa67b0be7ad8 100644
--- a/content/browser/download/download_resource_handler.cc
+++ b/content/browser/download/download_resource_handler.cc
@@ -380,10 +380,12 @@ void DownloadResourceHandler::OnResponseCompleted(
// to a user action.
// TODO(ahendrickson) -- Find a better set of codes to use here, as
// CANCELED/ERR_ABORTED can occur for reasons other than user cancel.
- if (net::IsCertStatusError(request()->ssl_info().cert_status))
+ if (net::IsCertStatusError(request()->ssl_info().cert_status) &&
+ !net::IsCertStatusMinorError(request()->ssl_info().cert_status)) {
reason = DOWNLOAD_INTERRUPT_REASON_SERVER_CERT_PROBLEM;
- else
+ } else {
reason = DOWNLOAD_INTERRUPT_REASON_USER_CANCELED;
+ }
}
if (status.is_success() &&
« chrome/browser/ui/toolbar/toolbar_model_impl.cc ('K') | « components/password_manager/content/browser/content_password_manager_driver.cc ('k') | content/browser/ssl/ssl_policy.cc » ('j') | content/browser/ssl/ssl_policy.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698