components/password_manager/content/browser/content_password_manager_driver.cc - Issue 508823009: Mark SHA-1 as deprecated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/content/browser/content_password_manager_driver.cc

Issue 508823009: Mark SHA-1 as deprecated (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@cert_verify_result_sha1

Patch Set: Moar work Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/toolbar/toolbar_model_impl.cc ('K') | « components/autofill/content/renderer/autofill_agent.cc ('k') | content/browser/download/download_resource_handler.cc » ('j') | content/browser/ssl/ssl_policy.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/content/browser/content_password_manager_driver.cc

diff --git a/components/password_manager/content/browser/content_password_manager_driver.cc b/components/password_manager/content/browser/content_password_manager_driver.cc

index 0c0e348c297c2d9c6aa4b7ecc409c4eccd240c84..e9851cbcd27bc789cf9be73810fc2ef454c5dd3e 100644

--- a/components/password_manager/content/browser/content_password_manager_driver.cc

+++ b/components/password_manager/content/browser/content_password_manager_driver.cc

@@ -89,7 +89,8 @@ bool ContentPasswordManagerDriver::DidLastPageLoadEncounterSSLErrors() {

return false;

}

- return net::IsCertStatusError(entry->GetSSL().cert_status);

+ return net::IsCertStatusError(entry->GetSSL().cert_status) &&

+ !net::IsCertStatusMinorError(entry->GetSSL().cert_status);

}

bool ContentPasswordManagerDriver::IsOffTheRecord() {