ash/shell_delegate.h - Issue 508813002: Move ownership of the AppListViewDelegate into the AppListService

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/shell_delegate.h

Issue 508813002: Move ownership of the AppListViewDelegate into the AppListService (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase to master Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/shell_delegate.h

diff --git a/ash/shell_delegate.h b/ash/shell_delegate.h

index d41132b5f78e15aea6a50dccd126f28fce9a8102..98059a9420c7c678a56fa5a1e54ddf0575dd9f04 100644

--- a/ash/shell_delegate.h

+++ b/ash/shell_delegate.h

@@ -113,7 +113,7 @@ class ASH_EXPORT ShellDelegate {

// Invoked to create an AppListViewDelegate. Shell takes the ownership of

James Cook 2014/09/18 23:29:55 nit: Is "Shell takes ownership" still correct?

tapted 2014/09/19 00:49:01 good catch - thought I got all of these :). Change

// the created delegate.

- virtual app_list::AppListViewDelegate* CreateAppListViewDelegate() = 0;

+ virtual app_list::AppListViewDelegate* GetAppListViewDelegate() = 0;

// Creates a new ShelfDelegate. Shell takes ownership of the returned

// value.

« no previous file with comments | « ash/shell/shell_delegate_impl.cc ('k') | ash/test/test_shell_delegate.h » ('j') | ash/wm/app_list_controller.cc » ('J')