Move ownership of the AppListViewDelegate into the AppListService

ash/shell_delegate.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_SHELL_DELEGATE_H_
 #define ASH_SHELL_DELEGATE_H_
 
 #include <string>
 
 #include "ash/ash_export.h"
@@ skipping 93 matching lines @@
   // Adds or removes virtual keyboard state observer.
   virtual void AddVirtualKeyboardStateObserver(
       VirtualKeyboardStateObserver* observer) = 0;
   virtual void RemoveVirtualKeyboardStateObserver(
       VirtualKeyboardStateObserver* observer) = 0;
 
   // Get the active browser context. This will get us the active profile
   // in chrome.
   virtual content::BrowserContext* GetActiveBrowserContext() = 0;
 
   // Invoked to create an AppListViewDelegate. Shell takes the ownership of

[James Cook, 2014/09/18 23:29:55]

nit: Is "Shell takes ownership" still correct?

[tapted, 2014/09/19 00:49:01]

good catch - thought I got all of these :). Changed to

  // Get the AppListViewDelegate, creating one if it does not yet exist.
  // Ownership stays with Chrome's AppListService, or the ShellDelegate.

   // the created delegate.
-  virtual app_list::AppListViewDelegate* CreateAppListViewDelegate() = 0;
+  virtual app_list::AppListViewDelegate* GetAppListViewDelegate() = 0;
 
   // Creates a new ShelfDelegate. Shell takes ownership of the returned
   // value.
   virtual ShelfDelegate* CreateShelfDelegate(ShelfModel* model) = 0;
 
   // Creates a system-tray delegate. Shell takes ownership of the delegate.
   virtual SystemTrayDelegate* CreateSystemTrayDelegate() = 0;
 
   // Creates a user wallpaper delegate. Shell takes ownership of the delegate.
   virtual UserWallpaperDelegate* CreateUserWallpaperDelegate() = 0;
@@ skipping 21 matching lines @@
   // Creates a GPU support object. Shell takes ownership of the object.
   virtual GPUSupport* CreateGPUSupport() = 0;
 
   // Get the product name.
   virtual base::string16 GetProductName() const = 0;
 };
 
 }  // namespace ash
 
 #endif  // ASH_SHELL_DELEGATE_H_